Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert 'suggest yarn install' script from Shell to JS #32356

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: convert 'suggest yarn install' script from Shell to JS #32356

merged 1 commit into from
Feb 20, 2024

Conversation

OnkarRuikar
Copy link
Contributor

Current script works well on Windows if

  • Gitbash used
  • C:\Program Files\Git\biin added to PATH

For some reason people don't wan't to use Gitbash. So to make it work without any change required from contributor's end we need to convert the script to NodeJs.

@OnkarRuikar OnkarRuikar requested review from mdn-bot and a team as code owners February 20, 2024 07:42
@OnkarRuikar OnkarRuikar requested review from pepelsbey and removed request for a team February 20, 2024 07:42
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Feb 20, 2024
@OnkarRuikar OnkarRuikar changed the title fix: convert suggest yarn install script from Shell to JS fix: convert 'suggest yarn install' script from Shell to JS Feb 20, 2024
@OnkarRuikar
Copy link
Contributor Author

ping @teoli2003 @hamishwillee

teoli2003
teoli2003 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

@teoli2003 teoli2003 merged commit 3dcf0a3 into mdn:main Feb 20, 2024
14 of 15 checks passed
@OnkarRuikar OnkarRuikar deleted the ci_fix_install_script2 branch February 20, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@mdn-bot mdn-bot Awaiting requested review from mdn-bot mdn-bot is a code owner

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @teoli2003