-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify client_metadata #32287
clarify client_metadata #32287
Conversation
It was not clear on first reading why the IdP is providing RP metadata. Hopefully this text helps provide clues to the reader earlier on.
Preview URLs (comment last updated: 2024-02-15 03:07:35) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. A little surprised that "Approve" is disabled for me here. Is this a deliberate choice? Plenty of other repos allow approvals from non-maintainers and just don't count those towards merging.
I don’t personally know, but I don’t myself have admin perms to the repo. As far as I know, the admin perms for the repo are limited to some Mozilla staff — who also administer the overall https://github.com/mdn/ org — and the decisions are made by them. |
Aaron, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉 (And thanks @tantek for the review) |
Description
Clarifies the use of the client metadata in relation to the IdP
Motivation
It was not clear on first reading why the IdP is providing RP metadata. Hopefully this text helps provide clues to the reader earlier on.