Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify client_metadata #32287

Merged
merged 2 commits into from
Feb 15, 2024
Merged

clarify client_metadata #32287

merged 2 commits into from
Feb 15, 2024

Conversation

aaronpk
Copy link
Contributor

@aaronpk aaronpk commented Feb 14, 2024

Description

Clarifies the use of the client metadata in relation to the IdP

Motivation

It was not clear on first reading why the IdP is providing RP metadata. Hopefully this text helps provide clues to the reader earlier on.

It was not clear on first reading why the IdP is providing RP metadata. Hopefully this text helps provide clues to the reader earlier on.
@aaronpk aaronpk requested a review from a team as a code owner February 14, 2024 23:24
@aaronpk aaronpk requested review from sideshowbarker and removed request for a team February 14, 2024 23:24
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Feb 14, 2024
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Preview URLs

(comment last updated: 2024-02-15 03:07:35)

Copy link
Contributor

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. A little surprised that "Approve" is disabled for me here. Is this a deliberate choice? Plenty of other repos allow approvals from non-maintainers and just don't count those towards merging.

@sideshowbarker
Copy link
Collaborator

A little surprised that "Approve" is disabled for me here. Is this a deliberate choice?

I don’t personally know, but I don’t myself have admin perms to the repo. As far as I know, the admin perms for the repo are limited to some Mozilla staff — who also administer the overall https://github.com/mdn/ org — and the decisions are made by them.

@sideshowbarker sideshowbarker merged commit bffb439 into mdn:main Feb 15, 2024
8 of 9 checks passed
@sideshowbarker
Copy link
Collaborator

Aaron, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉 (And thanks @tantek for the review)

@aaronpk aaronpk deleted the patch-2 branch February 15, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants