Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl.DurationFormat] fix comment/code mismatch #32284

Merged
merged 1 commit into from
Feb 14, 2024
Merged

[Intl.DurationFormat] fix comment/code mismatch #32284

merged 1 commit into from
Feb 14, 2024

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Feb 14, 2024

Description

The code comment doesn't match the example code, and also doesn't match the example output.

Motivation

It's incorrect and confusing

Additional details

This can only be tested using macOS due to limited cross-browser support for this feature

Related issues and pull requests

None

@k-yle k-yle requested a review from a team as a code owner February 14, 2024 21:07
@k-yle k-yle requested review from Josh-Cena and removed request for a team February 14, 2024 21:07
@github-actions github-actions bot added Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed labels Feb 14, 2024
Copy link
Contributor

@Josh-Cena Josh-Cena merged commit a7bac14 into mdn:main Feb 14, 2024
7 of 8 checks passed
@k-yle k-yle deleted the patch-2 branch February 14, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants