Add missing CORS header in preflight response example #32137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example preflight request sends an `Access-Control-Request-Headers` header, but the example response does not contain an `Access-Control-Allow-Headers` which is required as per https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers . This PR simply adds one.
github-actions
bot
added
Content:Glossary
|
Preview URLs (comment last updated: 2024-02-11 23:06:27) |
hamishwillee
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The preflight request page's example sends an
Access-Control-Request-Headersheader, but the example response does not contain anAccess-Control-Allow-Headerswhich is required. This PR simply adds one.Motivation
Readers may believe that a server (wanting a preflight request to succeed) doesn't need to respond with an
Access-Control-Allow-Headersheader if the client sends anAccess-Control-Request-Headersheader.Additional details
N/A
Related issues and pull requests
N/A