-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #32105 | Fix incorrect note about autocomplete
attribute of <input>
element of button
type
#32112
Conversation
Co-authored-by: dawei-wang <[email protected]>
autocomplete
attribute of <input>
element of button
typeautocomplete
attribute of <input>
element of button
type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following pages need note about firefox default behavior.
I've search the stackflow link https://stackoverflow.com/questions/5985839/bug-with-firefox-disabled-attribute-of-input-not-resetting-when-refreshing, and it existed in following documentations:
so I assume above documentations need not to add more note but, there is still a lot of tasks |
Co-authored-by: shubham oulkar <[email protected]>
yup, Notes are present.
I think Note should not be under disabled attribute for page If you agree, I suggest you to add note under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skyclouds2001 for this work. Thank you and @ShubhamOulkar both for checking other pages that might need to be updated 🙌
I have added a few suggestions along with the rewording edit.
Hi @skyclouds2001, I'm following up on this PR. |
Hi @skyclouds2001, I understand things can get busy. To keep the momentum going on this PR and so that it doesn't become stale, I've gone ahead and merged it with the changes I suggested. I've also adjusted the PR description to remove Appreciate your understanding and contributions! |
Description
fix incorrect note about
autocomplete
attribute of<input>
element ofbutton
type, the note should not talk about<button>
also remove the similar note existed in
<button>
elementrelates with #31605 and mdn/browser-compat-data#21876
also cc @ShubhamOulkar
Motivation
Additional details
Related issues and pull requests
#32105