Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32105 | Fix incorrect note about autocomplete attribute of <input> element of button type #32112

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Feb 4, 2024

Description

fix incorrect note about autocomplete attribute of <input> element of button type, the note should not talk about <button>

also remove the similar note existed in <button> element

relates with #31605 and mdn/browser-compat-data#21876

also cc @ShubhamOulkar

Motivation

Additional details

Related issues and pull requests

#32105

@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Feb 4, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review February 4, 2024 19:01
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner February 4, 2024 19:01
@skyclouds2001 skyclouds2001 requested review from dipikabh and removed request for a team February 4, 2024 19:01
@skyclouds2001 skyclouds2001 changed the title FIx #32105 | Fix incorrect note about autocomplete attribute of <input> element of button type Fix #32105 | Fix incorrect note about autocomplete attribute of <input> element of button type Feb 5, 2024
Copy link
Contributor

@ShubhamOulkar ShubhamOulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files/en-us/web/html/element/input/button/index.md Outdated Show resolved Hide resolved
@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Feb 5, 2024

Following pages need note about firefox default behavior.

I had tested for range, checkbox and radio input types.

I've search the stackflow link https://stackoverflow.com/questions/5985839/bug-with-firefox-disabled-attribute-of-input-not-resetting-when-refreshing, and it existed in following documentations:

  • Web/HTML/Attributes/autocomplete
  • Web/HTML/Element/button (under disabled attribute) [a mistake here and should be removed]
  • Web/HTML/Element/input (under disabled attribute)
  • Web/HTML/Element/input/button (under a sample about disabled attribute)
  • Web/HTML/Element/input/checkbox (under checked attribute)
  • Web/HTML/Element/input/radio (under checked attribute)

so I assume above documentations need not to add more note

but, there is still a lot of tasks

@ShubhamOulkar
Copy link
Contributor

ShubhamOulkar commented Feb 6, 2024

so I assume above documentations need not to add more note

yup, Notes are present.

Web/HTML/Element/input (under disabled attribute)

I think Note should not be under disabled attribute for page en-US/docs/Web/HTML/Element/input.

If you agree, I suggest you to add note under autocomplete attribute.

@dipikabh dipikabh self-assigned this Feb 6, 2024
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skyclouds2001 for this work. Thank you and @ShubhamOulkar both for checking other pages that might need to be updated 🙌

I have added a few suggestions along with the rewording edit.

files/en-us/web/html/element/input/button/index.md Outdated Show resolved Hide resolved
@dipikabh dipikabh added the awaiting response Awaiting for author to address review/feedback label Feb 20, 2024
@dipikabh
Copy link
Contributor

Hi @skyclouds2001, I'm following up on this PR.
Would you have a moment to check out the feedback sometime soon so we can land these updates? Happy to clarify anything if required. Thanks!

@dipikabh
Copy link
Contributor

dipikabh commented Mar 7, 2024

Hi @skyclouds2001, I understand things can get busy. To keep the momentum going on this PR and so that it doesn't become stale, I've gone ahead and merged it with the changes I suggested.

I've also adjusted the PR description to remove fixes until we've addressed all the pages that need to be updated for a complete fix.

Appreciate your understanding and contributions!

@dipikabh dipikabh merged commit cc032ea into mdn:main Mar 7, 2024
9 checks passed
@dipikabh dipikabh removed the awaiting response Awaiting for author to address review/feedback label Mar 7, 2024
@skyclouds2001 skyclouds2001 deleted the input-button-autocomplete branch April 3, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants