Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Web/API/Houdini to Web/API/Houdini_APIs | fix the reference bug #31677

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 12, 2024

Description

in https://developer.mozilla.org/en-US/docs/Web/API, the Houdini is a broken link:

image

this is because the overview key does not match the summary page

image

sso choose to move the api summary page, also match the behavior of other apis (especially Sensor APIs)

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:Glossary Glossary entries labels Jan 12, 2024
Copy link
Contributor

github-actions bot commented Jan 12, 2024

Preview URLs (16 pages)
Flaws (7)

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CSS_Object_Model
Title: CSS Object Model (CSSOM)
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/CSSFontFeatureValuesMap does not exist
    • /en-US/docs/Web/API/CSSMarginRule does not exist

URL: /en-US/docs/Web/API/PaintWorkletGlobalScope
Title: PaintWorkletGlobalScope
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/PaintWorkletGlobalScope/devicePixelRatio
Title: PaintWorkletGlobalScope: devicePixelRatio property
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/PaintWorkletGlobalScope/registerPaint
Title: PaintWorkletGlobalScope: registerPaint() method
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/CSS_Painting_API
Title: CSS Painting API
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PaintRenderingContext2D does not exist
    • /en-US/docs/Web/API/PaintSize does not exist

(comment last updated: 2024-01-17 10:28:26)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 12, 2024 08:27
@skyclouds2001 skyclouds2001 requested review from a team as code owners January 12, 2024 08:27
@skyclouds2001 skyclouds2001 requested review from Elchi3 and chrisdavidmills and removed request for a team January 12, 2024 08:27
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @skyclouds2001. The change largely makes sense to me, although I've made some suggestions that would make the link text more consistent.

I also think we should get @estelle's blessing on this one — it was her that moved the Houdini landing page under /APIs recently, as part of the project to remove the /Guide tree.

files/en-us/glossary/houdini/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/css_object_model/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/css_painting_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/css_properties_and_values_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@property/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@property/inherits/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@property/initial-value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@property/syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_properties_and_values_api/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just get this one merged; I don't think there is anything too controversial in here, thinking about it some more. Sorry for the delay.

@chrisdavidmills chrisdavidmills merged commit 3b39e41 into mdn:main Jan 17, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the houdini branch January 17, 2024 13:04
@estelle
Copy link
Member

estelle commented Jan 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants