-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(relnote): FF122 - Support enabled for motion path features #31514
Conversation
```css | ||
ray() = ray( <angle> && <size>? && contain? && [at <position>]? ) | ||
<size> = closest-side | closest-corner | farthest-side | farthest-corner | sides | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this manually added syntax. "Formal syntax" shows the latest syntax now.
### Description - Fixes #676 To address listing the values for `<ray-size>`, I've referred to the instructions in the `mdn/data/docs` section [Store the information in the JSONs](https://github.com/mdn/data/blob/main/docs/updating_css_json.md#store-the-information-in-the-jsons), where it mentions how to handle when "syntax contains references to specific values". I've added `"syntaxes"` for `ray()` in `syntaxes.json`. I've included only the keys that have further values. I'm not sure if that's the correct way to do it though. I am assuming this should be okay because the complete syntax exists in `functions.json`. **UPDATE**: `"syntaxes"` is not supported, was getting lint errors. I've reverted to use `syntax` but expanded the `<ray-size>` and `<position>` values inline. - I'm also using this PR to update `ray()` function syntax (mdn/content PR to add [Formal syntax](https://pr31514.content.dev.mdn.mozit.cloud/en-US/docs/Web/CSS/ray#formal_syntax)). With Firefox122 coming out on Jan 23, 2024, `ray()` will be supported by default, making it standard across browsers. So I've also updated the status to `standard` (BCD PR with [ray() status update](https://github.com/mdn/browser-compat-data/pull/21844/files#diff-5153a0172f96a72ece248c9d29cea659e3ecd45c45d81d57b0b6f2f00c57e7b3R98)). ### Motivation Addressing an issue as well as updating the syntax ### Related issues and pull requests mdn/browser-compat-data#21844 mdn/content#31514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Thanks for reviewing, @pepelsbey and @estelle! |
…31514) * relnotes for motion path * remove syntax
Target release: Firefox 122
Release date: Jan 23, 2024
Description
The following preferences have been enabled by default in Firefox 122:
layout.css.motion-path-ray.enabled
layout.css.motion-path-offset-position.enabled
layout.css.motion-path-basic-shapes.enabled
layout.css.motion-path-coord-box.enabled
layout.css.motion-path-url.enabled
Changes
ray()
,offset-position
, andurl()
Related issues and pull requests
https://bugzilla.mozilla.org/show_bug.cgi?id=1598151
https://bugzilla.mozilla.org/show_bug.cgi?id=1598152
https://bugzilla.mozilla.org/show_bug.cgi?id=1598159