Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Reference for Sets: Fix broken internal link to set methods #31447

Merged

Conversation

cristi-contiu
Copy link
Contributor

@cristi-contiu cristi-contiu commented Jan 1, 2024

Description

Fixes broken internal link to set methods in the JavaScript Reference Sets page.

Motivation

The existing internal link "set methods" in the paragraph "All set methods require this to be an actual Set instance" under the heading "Set-like objects" is not working.

Additional details

The Set methods link currently points to "#set_methods", but this no longer exists in the page. The correct internal anchor should be "#instance_methods".

Related issues and pull requests

@cristi-contiu cristi-contiu requested a review from a team as a code owner January 1, 2024 13:54
@cristi-contiu cristi-contiu requested review from Josh-Cena and removed request for a team January 1, 2024 13:54
@github-actions github-actions bot added the Content:JS JavaScript docs label Jan 1, 2024
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Preview URLs

(comment last updated: 2024-01-01 15:02:43)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks

@teoli2003 teoli2003 merged commit db9d4a1 into mdn:main Jan 1, 2024
7 checks passed
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
…1447)

* JS Reference on Sets: Fix internal link

* Update files/en-us/web/javascript/reference/global_objects/set/index.md

---------

Co-authored-by: Joshua Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants