Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

31113 popover nightly #31154

Merged
merged 10 commits into from
Dec 21, 2023
Merged

31113 popover nightly #31154

merged 10 commits into from
Dec 21, 2023

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Dec 19, 2023 •
edited
Loading

Description

Added relavant see also links to the various pages that relate to popover

Motivation

Working on making sure popover is documented for default release in nightly

Related issues and pull requests

@dletorey dletorey requested review from a team as code owners December 19, 2023 14:35
@dletorey dletorey requested review from Elchi3 and estelle and removed request for a team December 19, 2023 14:35
@dletorey dletorey mentioned this pull request Dec 19, 2023
Merged
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs labels Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Preview URLs (10 pages)

(comment last updated: 2023-12-21 21:51:14)

This was referenced Dec 19, 2023
Merged
Closed
estelle
estelle requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you're adding these links.
Just one edit (the same edit, but multiple instances)

@dletorey
Copy link
Contributor Author

Glad you're adding these links. Just one edit (the same edit, but multiple instances)

@estelle I can not see what this one edit is. Perhaps I'm missing something.

estelle
estelle approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit e492ae4 into mdn:main Dec 21, 2023
7 checks passed
@dletorey dletorey deleted the 31113-popover-nightly branch January 8, 2024 11:57
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@dletorey @estelle @dipikabh
31113 popover nightly (mdn#31154)
69b6e91 
* added see also links to popover api and attribute pages

* added see also links to related CSS pseudo-element & class

* added see also links to the html apis related to popover

* Update files/en-us/web/html/global_attributes/popover/index.md

Co-authored-by: Estelle Weyl <[email protected]>

* removed the reference to button in the see also as it applies to input too

---------

Co-authored-by: Estelle Weyl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dletorey @estelle