-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the mix-blend-mode
CSS property page: add plus-darker
and plus-lighter
values
#31095
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2023-12-27 10:44:12) |
In values, we use two terms, highlighted in italics, that need to be defined.
I am not even finding these in the canvas section, which is where i thought they originated. If they did originate there, we should find the definition or define them there and link the definitions. Otherwise, we should state what they do/are. Can we add the values to the example at /en-US/docs/Web/CSS/mix-blend-mode#effect_of_different_mix-blend-mode_values as all the other keyterm values are included there? Seeing the effect may help with users understanding what the compositing operator does. Should we add |
Is As it is a recent value, I added it in openwebdocs/mdn-bcd-collector#991 so that it can be detected by the collector: the bcd table should stay up-to-date that way. |
The specification defines these values directly through their corresponding Porter Duff compositing operators. Apparently there is no other definition for them at the moment. Updated the file again to add these two values to the examples section. Basing on w3c/fxtf-drafts#447, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suggest we link to the porter-duff compositing operator
Add two recently added values to the "Values" section. The `plus-lighter` value is already mentioned in the compat table
Co-authored-by: Estelle Weyl <[email protected]>
The suggested changes are now applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
…`plus-lighter` values (mdn#31095) * Add `plus-darker` and `plus-lighter` values to the "Values" section Add two recently added values to the "Values" section. The `plus-lighter` value is already mentioned in the compat table * fix a typo * Add plus-darker and plus-lighter to the example section * Add links to the spec as suggested in code review Co-authored-by: Estelle Weyl <[email protected]> --------- Co-authored-by: Estelle Weyl <[email protected]>
Description
Add two recently added values
plus-darker
andplus-lighter
to the "Values" section.Motivation
The specification has been updated recently to add two more values in addition to those listed in the
<blend-mode>
data type. The "Browser compatibility" section already lists theplus-lighter
value but the "Values" section still misses both of them.Additional details
The
plus-lighter
value is particularly useful for the cross-fade effects, as explained in the specification itself and in this article by Jake ArchibaldRelated issues and pull requests
This PR doesn't depend on other issues or PRs