-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: MDN React Tutorials #5: Interactivity #31093
Conversation
Preview URLs (comment last updated: 2023-12-21 11:53:28) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all yours, @chrisdavidmills!
I did less editing overall than I've done in other files so far – mostly just minor line-edits, outside of a new block of code to be sure that the reader can check their progress.
@@ -240,7 +241,91 @@ Bind this function to the form's `submit` event by adding the following `onSubmi | |||
<form className="stack-small" onSubmit={handleSubmit}> | |||
``` | |||
|
|||
You should now be able to edit a task in your browser! | |||
You should now be able to edit a task in your browser. At this point, your `Todo.jsx` file should look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 There's a big ol' block of code after this line so the reader can double-check the state (lol) of their code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mxmason fabulous work! I've gone through the whole tutorial and tested it out again, and my sample app is working perfectly. I've got no comments for you to look at (I just made a very small change to the text that wasn't really worth discussing), so approving.
On to the next one!
* chore: edit 1 * chore: add checkpoint code * chore: edit filterbutton check-in code * Small tweak --------- Co-authored-by: Chris Mills <[email protected]>
Description
Following #30977, as part of mdn/mdn#474, this PR makes some modifications to the fifth page in our "Getting started with React" tutorial.
Do not merge this until #30977 has been merged and you have updated this PR with mdn main and checked for breakages.