Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mediastream & MediaStreamTrack | fix and move a sentence & update text #31082

Merged
merged 4 commits into from
Dec 17, 2023
Merged

Mediastream & MediaStreamTrack | fix and move a sentence & update text #31082

merged 4 commits into from
Dec 17, 2023

Conversation

skyclouds2001
Copy link
Contributor

Description

fix and move a sentence:

Some user agents subclass this interface to provide more precise information or functionality, like in {{domxref("CanvasCaptureMediaStreamTrack")}}.

from MediaStream to MediaStreamTrack, as CanvasCaptureMediaStreamTrack inherits from MediaStreamTrack

also add HTMLMediaElement.captureStream() method which can also be used to get a MediaStream

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2023 •
edited
Loading

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/MediaStream
Title: MediaStream
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/MediaStream/active_event does not exist
    • /en-US/docs/Web/API/MediaStream/inactive_event does not exist

(comment last updated: 2023-12-17 22:59:03)

@skyclouds2001 skyclouds2001 changed the title Mediastream Mediastreamtrack | fix a sentence & update text Mediastream & MediaStreamTrack | fix and move a sentence & update text Dec 17, 2023
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 17, 2023 10:52
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 17, 2023 10:52
@skyclouds2001 skyclouds2001 requested review from wbamberg and removed request for a team December 17, 2023 10:52
hamishwillee
hamishwillee approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@hamishwillee hamishwillee merged commit 7b5577c into mdn:main Dec 17, 2023
7 checks passed
@skyclouds2001 skyclouds2001 deleted the mediastream-mediastreamtrack branch December 18, 2023 02:55
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@skyclouds2001 @hamishwillee @dipikabh
Mediastream & MediaStreamTrack | fix and move a sentence & update text (
8a947c5 
mdn#31082)

* fix: CanvasCaptureMediaStreamTrack inherit from MediaStreamTrack, not MediaStream

* update condition

* update text

* Update files/en-us/web/api/mediastreamtrack/index.md

---------

Co-authored-by: Hamish Willee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @hamishwillee