Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected definition of HTMLIFrameElement's src property #31080

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Corrected definition of HTMLIFrameElement's src property #31080

merged 2 commits into from
Dec 17, 2023

Conversation

yg-i
Copy link
Contributor

@yg-i yg-i commented Dec 17, 2023

  1. replaced incorrect definition of HTMLIFrameElement's src property with the definition at https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement#:~:text=HTMLIFrameElement.src

  2. renamed two variables in the Syntax section accordingly

1. replaced incorrect definition of HTMLIFrameElement's src property with the definition at https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement#:~:text=HTMLIFrameElement.src

2. renamed two variables in the Syntax section accordingly
@yg-i yg-i requested a review from a team as a code owner December 17, 2023 09:30
@yg-i yg-i requested review from wbamberg and removed request for a team December 17, 2023 09:30
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 17, 2023
Copy link
Contributor

github-actions bot commented Dec 17, 2023

Preview URLs

Flaws (3)

URL: /en-US/docs/Web/API/HTMLIFrameElement/src
Title: HTMLIFrameElement: src property
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/HTMLAnchorElement/src does not exist
    • /en-US/docs/Web/API/HTMLAreaElement/src does not exist
    • /en-US/docs/Web/API/HTMLAreaElement/src does not exist

(comment last updated: 2023-12-17 15:46:18)

@mdn mdn deleted a comment from github-actions bot Dec 17, 2023
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @yg-i !

@wbamberg wbamberg merged commit 1862c53 into mdn:main Dec 17, 2023
7 checks passed
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
* replaced incorrect definition

1. replaced incorrect definition of HTMLIFrameElement's src property with the definition at https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement#:~:text=HTMLIFrameElement.src

2. renamed two variables in the Syntax section accordingly

* typography; remove unneeded browser version info

---------

Co-authored-by: wbamberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants