Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Module: syntax (and error handling guide) #31022

Closed
wants to merge 33 commits into from
Closed

Conversation

estelle
Copy link
Member

@estelle estelle commented Dec 15, 2023

The original task was to update the charset module. Turns out there is no such thing.
Charset was defined in CSS 2 but removed in the CSS syntax module.

  • Move css_charset to css_syntax.
  • Created a new document: css_syntax. This is a module landing page. It includes the key concepts introduced in that module.
  • Created a new document: a guide on CSS error handling by the parser. a subpage for CSS syntax.
  • Updated the @charset page to indicate that it is NOT an at-rule, and has been deprecated in css-syntax.
  • Updated custom-ident, the page that had the best explanation of CSS escape characters, adding a separate section for escaping characters in CSS. This PR does not include creating links to that section. That will be done as a separate PR (this PR is already big enough)

related to openwebdocs/project#186

This PR was previously reviewed and is now co-authored by @dipikabh. See #30793

estelle and others added 30 commits December 4, 2023 20:29
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle requested review from a team as code owners December 15, 2023 08:19
@estelle estelle requested review from chrisdavidmills and removed request for a team December 15, 2023 08:19
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Dec 15, 2023
files/en-us/web/css/css_syntax/error_handling/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_syntax/error_handling/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_syntax/error_handling/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_syntax/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/custom-ident
Title: <custom-ident>

(comment last updated: 2023-12-15 08:29:31)

estelle and others added 2 commits December 15, 2023 00:22
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants