Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix apiref of CookieStoreManager and some word fix #30917

Merged
merged 6 commits into from
Dec 15, 2023
Merged

fix apiref of CookieStoreManager and some word fix #30917

merged 6 commits into from
Dec 15, 2023

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 11, 2023 •
edited
Loading

Description

fix apiref of CookieStoreManager

use {{jsxref("Promise")}} instead of {{jsxref("promise")}}

adding {{AvailableInWorkers}}, waiting for mdn/yari#10029 for better using experimence

some other fix

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

Preview URLs

Flaws (1)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CookieStoreManager
Title: CookieStoreManager
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/ServiceWorkerRegistration/cookies does not exist

(comment last updated: 2023-12-13 03:59:20)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 11, 2023 08:53
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 11, 2023 08:53
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team December 11, 2023 08:53
@skyclouds2001 skyclouds2001 marked this pull request as draft December 13, 2023 03:54
teoli2003
teoli2003 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

teoli2003
teoli2003 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops too early.

@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Dec 15, 2023 •
edited
Loading

I guess we could go ahead first not waiting for mdn/yari#10029 and update the usage of {{AvailableInWorkers}} afterwards

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 15, 2023 07:47
teoli2003
teoli2003 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of self, but we don't have an official policy here.

@teoli2003 teoli2003 merged commit 255d2a5 into mdn:main Dec 15, 2023
7 checks passed
@skyclouds2001 skyclouds2001 deleted the CookieStoreManager branch December 15, 2023 08:11
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@skyclouds2001 @dipikabh
fix apiref of CookieStoreManager and some word fix (mdn#30917)
3b807ec 
* fix apiref

* fix word

* add ,

* use self prefix

* style update

* add AvailableInWorkers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @teoli2003