-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editorial review: Fenced Frames docs #30874
Conversation
Co-authored-by: Estelle Weyl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance there are SVGs of these files? It's easier for maintenance & keeping bins out of the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't provided with any, sorry. These came from the Chrome dev rel team. I'll ask around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be awesome, not a blocker 🙏🏻
files/en-us/web/api/fenced_frame_api/communication_with_embedded_frames/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/fenced_frame_api/communication_with_embedded_frames/index.md
Show resolved
Hide resolved
files/en-us/web/api/fenced_frame_api/communication_with_embedded_frames/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/fenced_frame_api/communication_with_embedded_frames/index.md
Outdated
Show resolved
Hide resolved
@chrisdavidmills I'm done taking a look for now, a couple of comments for your consideration 🙌🏻 |
Thanks so much for the helpful comments, @bsmth! I have responded to all your comments so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, thanks so much @bsmth! I am still chasing SVG images, but I won't block on that.
Well, y'know, this PR came from the dark days before I promised to limited PR sizes a bit ;-) |
I presume you meant to hit |
I did not even notice that; an even cooler PR to land than it was before ;-) |
Description
#27781 contains the engineering technical review for my work on Fenced Frames docs, which has been completed and approved. Thank you to @gtanzer and others for your thorough and detailed review work.
This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.
Background information
Fenced frames are an integral part of Google's privacy sandbox technologies. Many parts of this set are being made available by default in Chrome 115 (depending on a gradual ramp up to 100% of userbase over the 115 release period).
See my research document for more details of exactly what changes are expected in the PR.
Motivation
Additional details
Related issues and pull requests