Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to logic in centenarian example #30746

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Fix to logic in centenarian example #30746

merged 1 commit into from
Dec 3, 2023

Conversation

jimmonte
Copy link
Contributor

@jimmonte jimmonte commented Dec 2, 2023

Age need not be integral, and someone who is, for example, 99.5 years old is not a centenarian.

Description

Motivation

Additional details

Related issues and pull requests

Age need not be integral, and someone who is, for example, 99.5 years old is not a centenarian.
@jimmonte jimmonte requested a review from a team as a code owner December 2, 2023 23:58
@jimmonte jimmonte requested review from Josh-Cena and removed request for a team December 2, 2023 23:58
@github-actions github-actions bot added the Content:JS JavaScript docs label Dec 2, 2023
Copy link
Contributor

github-actions bot commented Dec 2, 2023

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't set the value range for age... But sure, this should be better 😄

@Josh-Cena Josh-Cena merged commit 0922a6e into mdn:main Dec 3, 2023
6 checks passed
estelle pushed a commit to estelle/content that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants