Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editorial review — Related website sets docs #30654

Merged
merged 68 commits into from
Dec 20, 2023

Conversation

chrisdavidmills
Copy link
Contributor

Description

#30500 contains the engineering technical review for my work on Storage Access API and related website sets docs, which has been completed and approved. Thank you to @cfredric and @tunetheweb for your thorough and detailed review work.

This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.


Background information

Related website sets is a part of Chrome's privacy sandbox project. It provides progressive enhancement for The Storage Access API, allowing the definition of a set of related, trusted sites that can receive automatic permission to access third party cookies originating from the set.

This PR aims to do the following:

  • Write a Related website sets page, nested under the Storage Access API page.
  • Document the Chrome-only Document.requestStorageAccessFor() method and add mentions and links in appropriate places
  • Update the main Storage Access API page to mention the above and provide an up-to-date picture of the API
  • Update the Using the Storage Access API page to include details of the above.
  • Update mentions of "first-party sets" to "related website sets"
  • Update permissions API information to include the top-level-storage-access permission feature name specific to requestStorageAccessFor(), and make sure the storage-access feature is marked as supported in Fx.

Motivation

Additional details

Related issues and pull requests

chrisdavidmills and others added 30 commits November 24, 2023 13:13
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chrisdavidmills and others added 21 commits December 19, 2023 10:30
@chrisdavidmills
Copy link
Contributor Author

@teoli2003 thanks for the fabulous review! I have responded to all your comments, so the bulk of the content is now ready for another run through.

I've also added some new information about .well-known file requirements and security to the related website sets document. I only found this information very recently.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 65f4a29 into mdn:main Dec 20, 2023
8 checks passed
@chrisdavidmills chrisdavidmills deleted the related-website-sets branch December 20, 2023 09:01
Tenkir pushed a commit to Tenkir/content that referenced this pull request Dec 22, 2023
* Related website sets docs

* Rest of required content

* Fix broken link

* Updated status for RWS

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/privacy/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix description list linter mess

* Fixes for cfredric tech review comments

* address cfredric and tunetheweb feedback

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* More tinkering with descriptions

* more small tweaks, link fix

* Fix quote style - single to double

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/http/cookies/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/hasstorageaccess/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccess/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccess/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* responding to the rest of teoli2003s comments

* Add RWS well-known file and security information

---------

Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jean-Yves Perrier <[email protected]>
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
* Related website sets docs

* Rest of required content

* Fix broken link

* Updated status for RWS

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/privacy/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix description list linter mess

* Fixes for cfredric tech review comments

* address cfredric and tunetheweb feedback

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Chris Fredrickson <[email protected]>

* More tinkering with descriptions

* more small tweaks, link fix

* Fix quote style - single to double

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/related_website_sets/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/using/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/http/cookies/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/storage_access_api/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/hasstorageaccess/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccess/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccess/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/api/document/requeststorageaccessfor/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* responding to the rest of teoli2003s comments

* Add RWS well-known file and security information

---------

Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:Other Any docs not covered by another "Content:" label Content:Security Security docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants