29787 text wrap

[dletorey]

Description

• Added the different values for text-wrap
• Added text-wrap to experimental features
• Added text-wrap 121 release note

Motivation

Working on the following Issues:

• Implement text-wrap:balance
• Enable CSS text-wrap: balance for all channels

Additional details

• Implement CSS text-wrap: balance
• Enable CSS text-wrap: balance for all channels

Related issues and pull requests

• BCD PR

[github-actions]

Preview URLs

• /en-US/docs/Mozilla/Firefox/Experimental_features
• /en-US/docs/Mozilla/Firefox/Releases/121
• /en-US/docs/Web/CSS/text-wrap

External URLs (3)

URL: /en-US/docs/Web/CSS/text-wrap
Title: text-wrap

• https://developer.chrome.com/blog/css-text-wrap-pretty/ (1 time) (Note! This may be a new URL 👀)

---

URL: /en-US/docs/Mozilla/Firefox/Releases/121
Title: Firefox 121 for developers

• https://bugzil.la/1731541 (1 time) (Note! This may be a new URL 👀)

---

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

• https://bugzil.la/1731541 (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2023-12-18 15:30:17)

[estelle]

We need to add the spec https://drafts.csswg.org/css-text-4/#white-space-property to the white-space page, as this property is part of that now shorthand value. We shouldn't remove css-text-3, though, until the shorthand syntax / values are supported.

I think the newer version you wrote was much easier for non-native speakers, but I still wasn't 100% in love with the section under description. I suggested an alternative for that entire section.

[pepelsbey]

Thank you! Merging it for tomorrow’s release. We can address any questions that might still left in the next PRs.

All the requests are seems to be resolved

[estelle]

@pepelsbey Do not dismiss reviews, especially without any attempts to reach out to request a re-review.

[pepelsbey]

@estelle I'm sorry but we needed this PR merged before tomorrow's Firefox 121 release. I asked @dletorey if your feedback was fully implemented and made the call. I hope you can still follow up on any potential issues left in a separate issue or PR. Thank you!

[Josh-Cena]

@dletorey @pepelsbey @zfox23 and other Mozilla folks: to make sure this doesn't happen again, please split your content PR and FF release note PR. The non-moz folks would likely not block your release notes so you can chill a bit about content. I know Hamish always does this.

[pepelsbey]

please split your content PR and FF release note PR

Yes, I fully agree. But it won't solve the problem, unfortunately: when some features get released in Firefox, we update not only release notes but also content. We were hoping a few weeks would be enough to get this review done. It wasn't, so I had to merge it.

I think we might also consider an approach where we can merge less than ideal pages first and then start improving them later. Otherwise, it stops developers from getting this information from MDN. The new text-wrap values were implemented in other browsers a while ago.

[Josh-Cena]

Any content that appears to users should be well-reviewed and agreed upon by parties involved. Reviewers not involved implicitly approve, but reviewers who explicitly disprove need to be given the chance for another round of review. This is one of the core reasons why we moved away from wiki: so we never have subpar pages getting into production :)

However, I agree we are missing an explicit timebox here. We need contributing guidelines for how long to wait for reviews.