fix: tref only works with xlink:href #30364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethFalco
requested review from
a team and
Ryuno-Ki
and removed request for
a team
|
Preview URLs |
Ryuno-Ki
approved these changes
Nov 18, 2023
|
Thank you. Also, congratulations on your first merged MDN content PR. Welcome to he team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some elements, namely
<cursor>,<filter>,<font-face-uri>,<glyphRef>, and<tref>only work withxlink:href, and nothref.The example was incorrectly using
hrefwhich clients, including ones that support SVG 2, will not render. I tested this in Eye of GNOME (GNOME's default image viewer.)Motivation
The SVG will now render correctly in viewers.
Additional details
Compare the list of nodes that support XLink's href to the SVG 2 href:
Nodes that are deprecated/removed in SVG 2 do not support the SVG 2
hrefattribute, soxlink:hrefmust still be used.I was investigating this following this comment in SVGO:
Related issues and pull requests