Add handling of answer message on the caller side #30316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
files/en-us/web/api/webrtc_api/signaling_and_video_calling/index.md
Outdated
Show resolved
Hide resolved
…ex.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Preview URLs Flaws (2)URL:
(comment last updated: 2023-12-02 17:17:38) |
wbamberg
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
👍 thank you @adnan-mujagic , and sorry to be slow to review your PR.
estelle
pushed a commit
to estelle/content
that referenced
this pull request
Dec 5, 2023
* Update index.md * Add handling answer msg * Update files/en-us/web/api/webrtc_api/signaling_and_video_calling/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Change order --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the missing part to the docs where the caller side is handling the answer message it receives from the callee side.
Motivation
This piece is important, it is present in illustrations featured earlier in the article, and is present in the sample server as well, but it was left out from the code section of the article, which might lead readers to believe that it isn't required.
Additional details
Here is the illustration that I am referring to, which shows this as the last step.
Related issues and pull requests
N/A