Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump Prettier to 3.1.0, content changes #30243

Closed
wants to merge 1 commit into from
Closed

chore(deps): Bump Prettier to 3.1.0, content changes #30243

wants to merge 1 commit into from

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 13, 2023

This PR includes some fixes in content required to get tests passing while bumping this dep.

Changes:

Tested on this branch:

 bsmth npm i -g [email protected]
...
 bsmth prettier -v
3.1.0
 bsmth prettier -c "**/*.md"
Checking formatting...
All matched files use Prettier code style!

@bsmth bsmth requested review from mdn-bot and a team as code owners November 13, 2023 16:55
@bsmth bsmth requested review from sideshowbarker and estelle and removed request for a team November 13, 2023 16:55
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:JavaScript Learning area JavaScript docs system [PR only] Infrastructure and configuration for the project labels Nov 13, 2023
bsmth
bsmth commented Nov 13, 2023
View reviewed changes
files/en-us/web/javascript/reference/operators/instanceof/index.md
@@ -215,7 +215,7 @@ if (!(mycar instanceof Car)) {
This is really different from:

```js example-bad
if (!mycar instanceof Car) {
if ((!mycar) instanceof Car) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to ignore / nolint this block

Copy link
Member

@Josh-Cena Josh-Cena Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, please add nolint

github-actions[bot]
github-actions bot reviewed Nov 13, 2023
View reviewed changes
files/en-us/learn/javascript/asynchronous/introducing_workers/index.md Show resolved Hide resolved
files/en-us/learn/javascript/asynchronous/introducing_workers/index.md Show resolved Hide resolved
...s/en-us/learn/tools_and_testing/client-side_javascript_frameworks/svelte_typescript/index.md Show resolved Hide resolved
...s/en-us/learn/tools_and_testing/client-side_javascript_frameworks/svelte_typescript/index.md Show resolved Hide resolved
...us/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Show resolved Hide resolved
files/en-us/web/api/webgl_api/by_example/hello_vertex_attributes/index.md Show resolved Hide resolved
files/en-us/web/api/webgl_api/by_example/textures_from_code/index.md Show resolved Hide resolved
files/en-us/web/javascript/reference/operators/import/index.md Show resolved Hide resolved
files/en-us/web/javascript/reference/operators/instanceof/index.md Show resolved Hide resolved
files/en-us/web/javascript/reference/template_literals/index.md Show resolved Hide resolved
@bsmth bsmth mentioned this pull request Nov 13, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (20 pages)
Flaws (16)

Note! 19 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLMarqueeElement
Title: HTMLMarqueeElement
Flaw count: 16

  • macros:
    • /en-US/docs/Web/API/HTMLMarqueeElement/behavior does not exist
    • /en-US/docs/Web/API/HTMLMarqueeElement/bgColor does not exist
    • /en-US/docs/Web/API/HTMLMarqueeElement/direction does not exist
    • /en-US/docs/Web/API/HTMLMarqueeElement/height does not exist
    • /en-US/docs/Web/API/HTMLMarqueeElement/hspace does not exist
    • and 11 more flaws omitted

teoli2003
teoli2003 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Happy to see MDN being so easy to adapt for a "medium" release like 3.1.0!

@teoli2003
Copy link
Contributor

@bsmth I think the failing test of Markdownlint is unrelated, but I'm not 100% sure. Let's rerun it to check.

@bsmth
Copy link
Member Author

bsmth commented Nov 13, 2023

I think the failing test of Markdownlint is unrelated, but I'm not 100% sure. Let's rerun it to check.

Yeah I'm not 100% certain why it's failing. Needs a proper look 👀

@bsmth bsmth added the do not merge [PR only] Not ready to land label Nov 13, 2023
@sideshowbarker sideshowbarker removed their request for review November 14, 2023 03:53
@teoli2003
Copy link
Contributor

I will try to add the prettier-induced changes to the other PR: that way, both the bump and the content changes will be in one single PR and there shouldn't be test failures (except the "System file changes" one).

I'm closing this one so we don't merge it by error. If it doesn't work, we can reopen it.

@teoli2003 teoli2003 closed this Nov 14, 2023
@bsmth bsmth deleted the prettier_3-1-0 branch January 19, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@teoli2003 teoli2003 teoli2003 approved these changes

@mdn-bot mdn-bot Awaiting requested review from mdn-bot mdn-bot is a code owner

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:JavaScript Learning area JavaScript docs Content:WebAPI Web API docs do not merge [PR only] Not ready to land system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsmth @teoli2003 @Josh-Cena