-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting technical summary table for <summary> #28602
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2023-10-20 00:32:17) |
@scottaohara apologies for the @, I was hoping to get your insight on this. Thank you. The MDN doc gives the following code as an example for using <details open>
<summary><h4>Overview</h4></summary>
<ol>
<li>Cash on hand: $500.00</li>
<li>Current invoice: $75.30</li>
<li>Due date: 5/6/19</li>
</ol>
</details> The doc currently has a warning following the example:
You have established that the "default role of button" statement is incorrect. And I believe the "this example will not work" is also not completely correct. I did some testing using my Mac's built-in VoiceOver feature. While the screen reader did not recognize the My questionHow can this warning be made more accurate in terms of its accessibility-related behavior? |
hi @Brian-Pob. writing to acknowledge i've seen your ping. I will come back to this asap. |
@Brian-Pob fortunately i've written quite a bit about this here. but at a high level, the note could be revised to call out that summary inconsistently maps to the button role, and the button role inconsistently treats its descendant elements as if they've been given a role of presentation | none. |
Noted. I will give your article a read. Thank you very much! |
@scottaohara Is this an acceptable rewrite of the warning? Btw, I've read through your whole article. It was very insightful. Thank you for writing and sharing it. |
sorry for the late reply, got buried in my other notifications. seems good to me with the update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
@estelle Thanks for merging the PR, but it looks like I never actually updated the warning in the document. I updated the technical summary but not the warning. Should I make a new PR? |
Description
Correcting the implicit ARIA role in the technical summary table for the
summary
element.Motivation
To ensure the MDN docs follow the relevant HTML specs.
Additional details
User scottaohara is an editor for the HTML AAM spec and the ARIA in HTML spec. He states in the linked issue that the table should:
Related issues and pull requests
Fixes #28446