Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs for notRestoredReasons #27947

Closed
wants to merge 16 commits into from

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Jul 14, 2023

Note: This technical review is now completed and approved. For the follow-on editorial review, see #32920


Description

The PerformanceNavigationTiming.notRestoredReasons property (see Back/forward cache notRestoredReasons API) is finally going to be launched in Chrome 123. This PR adds a reference page for the property and associated interfaces, and a guide to using it.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners July 14, 2023 12:28
@chrisdavidmills chrisdavidmills requested review from sideshowbarker and bsmth and removed request for a team July 14, 2023 12:28
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Preview URLs (15 pages)
Flaws (13)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PerformanceNavigationTiming/notRestoredReasons
Title: PerformanceNavigationTiming: notRestoredReasons property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.PerformanceNavigationTiming.notRestoredReasons

URL: /en-US/docs/Web/API/NotRestoredReasonDetails
Title: NotRestoredReasonDetails
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasonDetails

URL: /en-US/docs/Web/API/NotRestoredReasonDetails/toJSON
Title: NotRestoredReasonDetails: toJSON() method
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasonDetails.toJSON

URL: /en-US/docs/Web/API/NotRestoredReasonDetails/reason
Title: NotRestoredReasonDetails: reason property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasonDetails.reason

URL: /en-US/docs/Web/API/Performance_API/Reporting_backforward_cache_not_restored_reasons
Title: Reporting back/forward cache not restored reasons
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.PerformanceNavigationTiming.notRestoredReasons

URL: /en-US/docs/Web/API/NotRestoredReasons
Title: NotRestoredReasons
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons

URL: /en-US/docs/Web/API/NotRestoredReasons/toJSON
Title: NotRestoredReasons: toJSON() method
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons.toJSON

URL: /en-US/docs/Web/API/NotRestoredReasons/name
Title: NotRestoredReasons: name property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons.name

URL: /en-US/docs/Web/API/NotRestoredReasons/children
Title: NotRestoredReasons: children property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons.children

URL: /en-US/docs/Web/API/NotRestoredReasons/id
Title: NotRestoredReasons: id property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons.id

URL: /en-US/docs/Web/API/NotRestoredReasons/url
Title: NotRestoredReasons: url property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons.url

URL: /en-US/docs/Web/API/NotRestoredReasons/src
Title: NotRestoredReasons: src property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons.src

URL: /en-US/docs/Web/API/NotRestoredReasons/reasons
Title: NotRestoredReasons: reasons property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NotRestoredReasons.reasons
External URLs (11)

URL: /en-US/docs/Web/API/PerformanceNavigationTiming
Title: PerformanceNavigationTiming


URL: /en-US/docs/Web/API/PerformanceNavigationTiming/notRestoredReasons
Title: PerformanceNavigationTiming: notRestoredReasons property


URL: /en-US/docs/Web/API/NotRestoredReasonDetails
Title: NotRestoredReasonDetails


URL: /en-US/docs/Web/API/NotRestoredReasonDetails/reason
Title: NotRestoredReasonDetails: reason property


URL: /en-US/docs/Web/API/Performance_API
Title: Performance APIs


URL: /en-US/docs/Web/API/Performance_API/Reporting_backforward_cache_not_restored_reasons
Title: Reporting back/forward cache not restored reasons


URL: /en-US/docs/Web/API/NotRestoredReasons
Title: NotRestoredReasons


URL: /en-US/docs/Web/API/NotRestoredReasons/reasons
Title: NotRestoredReasons: reasons property

(comment last updated: 2024-03-29 11:30:17)

Copy link
Contributor

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add to the browser compat repo too?

@sideshowbarker sideshowbarker removed their request for review July 16, 2023 09:14
@chrisdavidmills
Copy link
Contributor Author

Is it possible to add to the browser compat repo too?

@tunetheweb I've done so; see mdn/browser-compat-data#20361

Copy link
Contributor

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've asked the devs to review as well.

@rubberyuzu
Copy link

rubberyuzu commented Jul 18, 2023

Thanks for working on this!
Sorry the explainer is a bit out of date and it needs some work around masking cross-origin frames. I will update it later.

  1. blocked is going to be called preventedBackForwardCache, and the possible value is "masked", "yes" and "no". Can you please update around blocked to reflect it? You can refer to this PR: Add back/forward cache NotRestoredReasons whatwg/html#9360

  2. url, reasons and children can be null for cross-origin frames. (We are currently discussing whether we mask them all or only partially. Please refer to the PR thread above.)

@tunetheweb
Copy link
Contributor

tunetheweb commented Jul 18, 2023

Thanks @rubberyuzu !

@chrisdavidmills this also answers the question of the spec - it will be added to the HTML spec once whatwg/html#9360 is merged and does list a set of reasons. Maybe we're better putting this back into draft until that lands and then update this PR appropriately?

@chrisdavidmills
Copy link
Contributor Author

Thanks @rubberyuzu !

@chrisdavidmills this also answers the question of the spec - it will be added to the HTML spec once whatwg/html#9360 is merged and does list a set of reasons. Maybe we're better putting this back into draft until that lands and then update this PR appropriately?

Yes, it would definitely be good to wait until this is in the spec. I'll put this into draft status for now.

Thanks for the input, @rubberyuzu and @tunetheweb

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 10, 2023
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Mar 21, 2024
@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Mar 27, 2024
@chrisdavidmills chrisdavidmills marked this pull request as ready for review March 27, 2024 15:28
Copy link
Contributor

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks for addressing the feedback!

@chrisdavidmills
Copy link
Contributor Author

@tunetheweb great, thanks for the review. I'm calling the tech review completed. Next stage is to close this PR, and open a new PR based on the same branch to contain the editorial review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants