-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds docs for notRestoredReasons #27947
Conversation
Preview URLs (15 pages)
Flaws (13)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (11)URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
(comment last updated: 2024-03-29 11:30:17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add to the browser compat repo too?
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performancenavigationtiming/notrestoredreasons/index.md
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
@tunetheweb I've done so; see mdn/browser-compat-data#20361 |
…e_not_restored_reasons/index.md Co-authored-by: Barry Pollard <[email protected]>
…e_not_restored_reasons/index.md Co-authored-by: Barry Pollard <[email protected]>
…nt into notrestoredreasons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've asked the devs to review as well.
Thanks for working on this!
|
Thanks @rubberyuzu ! @chrisdavidmills this also answers the question of the spec - it will be added to the HTML spec once whatwg/html#9360 is merged and does list a set of reasons. Maybe we're better putting this back into draft until that lands and then update this PR appropriately? |
Yes, it would definitely be good to wait until this is in the spec. I'll put this into draft status for now. Thanks for the input, @rubberyuzu and @tunetheweb |
This pull request has merge conflicts that must be resolved before it can be merged. |
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performance_api/reporting_backforward_cache_not_restored_reasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performancenavigationtiming/notrestoredreasons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performancenavigationtiming/notrestoredreasons/index.md
Show resolved
Hide resolved
files/en-us/web/api/performancenavigationtiming/notrestoredreasons/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks for addressing the feedback!
@tunetheweb great, thanks for the review. I'm calling the tech review completed. Next stage is to close this PR, and open a new PR based on the same branch to contain the editorial review. |
Note: This technical review is now completed and approved. For the follow-on editorial review, see #32920
Description
The
PerformanceNavigationTiming.notRestoredReasons
property (see Back/forward cache notRestoredReasons API) is finally going to be launched in Chrome 123. This PR adds a reference page for the property and associated interfaces, and a guide to using it.Motivation
Additional details
Related issues and pull requests