Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine _blank implicit noopener #2236

Merged
merged 4 commits into from
Feb 11, 2021
Merged

Conversation

kiding
Copy link
Contributor

@kiding kiding commented Feb 10, 2021

Some tags with their target to _blank have noopener by default. As mentioned in mdn/browser-compat-data#7642, this behavior is now part of the standard.

This PR removes the vendor/version-specific wordings, and adds links to the browser compatibility. The idea is that those who stumble upon the Window.opener document could easily end up at the corresponding compatibility data.

See: whatwg/html#4330

Removed the wordings that could imply the behavior is vendor-specific.
Added links to Browser compatibility for easy reference.
@kiding kiding requested review from a team as code owners February 10, 2021 08:36
@kiding kiding requested review from rachelandrew and jpmedley and removed request for a team February 10, 2021 08:36
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way we style notes has changed, so if you could update that while in here that would be fantastic.

@kiding kiding requested a review from rachelandrew February 11, 2021 03:09
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@rachelandrew rachelandrew merged commit 282b2a0 into mdn:main Feb 11, 2021
@kiding kiding deleted the _blank-implicit-noopener branch February 15, 2021 04:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants