-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for EXT_texture_norm16 #187
Conversation
Thanks @Elchi3 , I'll have a look at this soon. To answer your question, the version of kumascript inside the yari repo is the one to update. The kumascript repo will be archived soon. |
Thanks Chris, I will open a PR against Yari then. |
For the record, the repo is open for merges now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo one missing word and a few nits/suggestions
Co-authored-by: Michael[tm] Smith <[email protected]>
I set this to Draft status under the assumption that we don’t want it to end up getting merged until the SpecData change is merged and deployed. Did I assume correctly? |
The page builds without the macro change, so I'm not sure what the policy is. I've sent mdn/yari#2147 now. If needed, someone can review and merge that one first. |
Yeah I guess we should have a documented policy. But at it least seems like if the change gets deployed to production with the new macro also having been deployed, the resulting user experience for readers of the article is no ideal — I mean, given that the spec reference would then just show up as Unknown, without the actual intended link to the spec. |
I guess the procedure in that case is just to make sure the correc spec details are there before the content pr is made. I'll write something up. |
The Yari PR was merged. This is ready |
merged! |
Hi! I'd like to contribute new documentation for this new WebGL extension.
Spec: https://www.khronos.org/registry/webgl/extensions/EXT_texture_norm16/
BCD: mdn/browser-compat-data#7634
Question: This requires a new spec to be added for specData. Do I open a PR against https://github.com/mdn/yari/blob/master/kumascript/macros/SpecData.json or is it https://github.com/mdn/kumascript/blob/master/macros/SpecData.json?
Cheers and good luck for the launch today!