Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for EXT_texture_norm16 #187

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 14, 2020

Hi! I'd like to contribute new documentation for this new WebGL extension.

Spec: https://www.khronos.org/registry/webgl/extensions/EXT_texture_norm16/
BCD: mdn/browser-compat-data#7634

Question: This requires a new spec to be added for specData. Do I open a PR against https://github.com/mdn/yari/blob/master/kumascript/macros/SpecData.json or is it https://github.com/mdn/kumascript/blob/master/macros/SpecData.json?

Cheers and good luck for the launch today!

@Elchi3 Elchi3 requested a review from a team as a code owner December 14, 2020 16:40
@chrisdavidmills
Copy link
Contributor

Thanks @Elchi3 , I'll have a look at this soon.

To answer your question, the version of kumascript inside the yari repo is the one to update. The kumascript repo will be archived soon.

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 14, 2020

Thanks Chris, I will open a PR against Yari then.

@peterbe
Copy link
Contributor

peterbe commented Dec 14, 2020

For the record, the repo is open for merges now.

Copy link
Collaborator

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one missing word and a few nits/suggestions

files/en-us/web/api/ext_texture_norm16/index.html Outdated Show resolved Hide resolved
files/en-us/web/api/ext_texture_norm16/index.html Outdated Show resolved Hide resolved
files/en-us/web/api/ext_texture_norm16/index.html Outdated Show resolved Hide resolved
Co-authored-by: Michael[tm] Smith <[email protected]>
@sideshowbarker sideshowbarker marked this pull request as draft December 15, 2020 10:09
@sideshowbarker
Copy link
Collaborator

I set this to Draft status under the assumption that we don’t want it to end up getting merged until the SpecData change is merged and deployed. Did I assume correctly?

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 15, 2020

I set this to Draft status under the assumption that we don’t want it to end up getting merged until the SpecData change is merged and deployed. Did I assume correctly?

The page builds without the macro change, so I'm not sure what the policy is. I've sent mdn/yari#2147 now. If needed, someone can review and merge that one first.

@sideshowbarker
Copy link
Collaborator

The page builds without the macro change, so I'm not sure what the policy is.

Yeah I guess we should have a documented policy. But at it least seems like if the change gets deployed to production with the new macro also having been deployed, the resulting user experience for readers of the article is no ideal — I mean, given that the spec reference would then just show up as Unknown, without the actual intended link to the spec.

@chrisdavidmills
Copy link
Contributor

I guess the procedure in that case is just to make sure the correc spec details are there before the content pr is made. I'll write something up.

@Elchi3 Elchi3 marked this pull request as ready for review December 16, 2020 09:24
@Elchi3
Copy link
Member Author

Elchi3 commented Dec 16, 2020

The Yari PR was merged. This is ready

@chrisdavidmills chrisdavidmills merged commit 2d28c7c into mdn:main Dec 16, 2020
@chrisdavidmills
Copy link
Contributor

merged!

@Elchi3 Elchi3 deleted the webgl-ext-texture-norm16 branch December 16, 2020 09:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants