Add __proto__ key initializer to "Inheritance and the prototype chain"

[Josh-Cena]

Summary

Motivation

Close #16068

Supporting details

I've run some benchmarks:

https://jsben.ch/vLqVS

The __proto__ key turns out to be the fastest!

Related issues

Metadata

• Adds a new document
• Rewrites (or significantly expands) a document
• Fixes a typo, bug, or other error

[Josh-Cena]

TBH, I'm not entirely sure what the organization of this page is. We have "Different ways to create objects and the resulting prototype chain" as an H2 heading, and then "Summary of methods for extending the prototype chain" as a child H3 heading, which seems to describe how to create an object (inst) with a given prototype chain as well? Am I missing some nuance here?

On second thought I think maybe I can move my section to be parallel with class keyword, instead of parallel with Object.prototype.__proto__, but it's all a bit messy around here.

[sideshowbarker]

On second thought I think maybe I can move my section to be parallel with class keyword, instead of parallel with Object.prototype.__proto__, but it's all a bit messy around here.

That might be better yeah — but agreed, the organization of the page overall leaves a bit to be desired

[github-actions]

Preview URLs

• https://pr16090.content.dev.mdn.mozit.cloud/en-US/docs/Web/JavaScript/Inheritance_and_the_prototype_chain

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Inheritance_and_the_prototype_chain
Title: Inheritance and the prototype chain
on GitHub

No new external URLs

(this comment was updated 2022-05-17 11:18:17.182930)

[sideshowbarker]

Note to other reviewers: the reason this is an HTML table here rather than a Markdown table is that the corresponding existing sections of this article use similar HTML tables — so this is following the existing structure.

Probably we should replace all the HTML tables in the docs with Markdown tables, but that’s outside the scope of this patch.

[Josh-Cena]

In fact, I'm not entirely sure how that can be converted to a Markdown table: is there a syntax for <caption>?

[sideshowbarker]

In fact, I'm not entirely sure how that can be converted to a Markdown table: is there a syntax for <caption>?

The equivalent is to just have a paragraph that precedes the table.

[Josh-Cena]

/en-US/docs/Web/JavaScript/Reference/Object_initializer does not exist

Proof that I don't understand the KumaScript syntax... Need some guidance on how to point to the right document. Is using URL links the only way?

[sideshowbarker]

/en-US/docs/Web/JavaScript/Reference/Object_initializer does not exist

Proof that I don't understand the KumaScript syntax

In general it’s always OK to not use a KumaScript macro at all but instead just use a normal Markdown hyperlink — for example, object initializer

(Also worth mentioning that it’s OK to assume that existing content may have been written in a way that doesn’t follow current best practices, so you’re free to use your judgement to depart from the whatever (potentially bad) precedents may exist in whatever content you may be updating.)

[Josh-Cena]

Being a first-time contributor, I'm not really aware of what the best practices for MDN is. And TBH, as a docs framework developer myself, the biggest complaint I've heard is that "URL links are not stable enough" and "we want immutable doc references" which jsxref seems to be about😄

[Josh-Cena]

On second thought I think maybe I can move my section to be parallel with class keyword, instead of parallel with Object.prototype.__proto__

After a few re-reads I think I've got the gist of how the two places differ. I think the current approach makes more sense, but it's definitely not immediately apparent to a reader what the logical division is.

[Josh-Cena]

I'm slightly confused about the Netlify deploy preview: is it enabled for MDN?

[sideshowbarker]

I'm slightly confused about the Netlify deploy preview: is it enabled for MDN?

Dunno — where do you see it mentioned?

[Josh-Cena]

Ah, the action seems to be mdx-contributor-docs, which is not the same as the docs I'm editing.

[sideshowbarker]

Joshua, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

[Josh-Cena]

Thank you! ⭐️