Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine docs for selection events under GlobalEventHandlers #15385

Closed
wants to merge 1 commit into from

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 26, 2022

Another test for GlobalEventHandlers.

WebIDL:

partial interface mixin GlobalEventHandlers {
  attribute EventHandler onselectstart;
  attribute EventHandler onselectionchange;
};

Document includes GlobalEventHandlers
Window includes GlobalEventHandlers
HTMLElement includes GlobalEventHandlers
MathMLElement includes GlobalEventHandlers
SVGElement includes GlobalEventHandlers

Before this PR, there were these 6 pages:

  • Web/API/GlobalEventHandlers/onselectionchange
  • Web/API/GlobalEventHandlers/onselectstart
  • Web/API/Document/selectionchange_event
  • Web/API/Document/selectstart_event
  • Web/API/HTMLInputElement/selectionchange_event
  • Web/API/HTMLTextAreaElement/selectionchange_event

Now there are these 2 pages:

  • Web/API/GlobalEventHandlers/selectionchange_event
  • Web/API/GlobalEventHandlers/selectstart_event

@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Apr 26, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Selection
Title: Selection
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/selectionstart_event does not exist

URL: /en-US/docs/Web/API/Selection/containsNode
Title: Selection.containsNode()
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/GlobalEventHandlers/selectionchange_event
Title: selectionchange event
on GitHub
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.GlobalEventHandlers.selectionchange_event

URL: /en-US/docs/Web/API/GlobalEventHandlers/selectstart_event
Title: selectstart event
on GitHub
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.GlobalEventHandlers.selectstart_event

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 32

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/HTMLAllCollection does not exist
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • and 10 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document_Object_Model/Using_the_W3C_DOM_Level_1_Core
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 11 more flaws omitted

URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub
Flaw count: 10

  • macros:
    • /en-US/docs/Web/API/HTMLTextAreaElement/selectionchange_event redirects to /en-US/docs/Web/API/GlobalEventHandlers/selectionchange_event
    • /en-US/docs/Web/API/HTMLInputElement/selectionchange_event redirects to /en-US/docs/Web/API/GlobalEventHandlers/selectionchange_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/IDBDatabase/abort_event
    • Can't resolve /en-US/docs/Web/API/IDBDatabase/error_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/abort_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/resize_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/scroll_event
    • and 3 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub
Flaw count: 13

  • macros:
    • /en-US/docs/Web/HTML/Element/svg does not exist
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Window/appinstalled does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemail
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemailEvent
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemailStatus
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/Navigator/mozVoicemail
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/FMRadio
    • and 5 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/43
Title: Firefox 43 for developers
on GitHub
Flaw count: 8

  • macros:
    • /en-US/docs/Web/API/PerformanceRenderTiming does not exist
    • /en-US/docs/Web/API/PerformanceCompositeTiming does not exist
    • /en-US/docs/Web/API/Screen/mozOrientation does not exist
    • /en-US/docs/Web/API/Screen/onmozorientationchange does not exist
    • /en-US/docs/Web/API/Screen/mozLockOrientation does not exist
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Performance_Timeline_API
    • Can't resolve /en-US/docs/Plugins

External URLs

URL: /en-US/docs/Web/API/Selection
Title: Selection
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Selection/containsNode
Title: Selection.containsNode()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/GlobalEventHandlers/selectionchange_event
Title: selectionchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/GlobalEventHandlers/selectstart_event
Title: selectstart event
on GitHub


URL: /en-US/docs/Web/API/Selection_API
Title: Selection API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub

No new external URLs


URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub


URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Mozilla/Firefox/Releases/43
Title: Firefox 43 for developers
on GitHub

No new external URLs

@foolip
Copy link
Contributor

foolip commented May 4, 2022

Per https://w3c.github.io/selection-api/#selectionchange-event the "selectionchange" event can be fired at Document, HTMLInputElement and HTMLTextareaElement. I think it'd make sense to have these as 3 pages, and link them together. (I haven't tested if they're actually supported.)

@Elchi3
Copy link
Member Author

Elchi3 commented Aug 16, 2022

Closing as folks went with a different solution. mdn/browser-compat-data#16029 (comment)

@Elchi3 Elchi3 closed this Aug 16, 2022
@Elchi3 Elchi3 deleted the globalevent-selection branch August 16, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants