Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template literals: changed explanation about illegal escape sequences #12885

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

HolgerJeromin
Copy link
Contributor

Summary

Removed link to fixed issue.
Instead linked to existing explanation.

Motivation

Supporting details

https://2ality.com/2016/09/template-literal-revision.html
tc39/proposal-template-literal-revision#5
https://github.com/tc39/notes/blob/HEAD/meetings/2017-03/mar-21.md#10ia-template-literal-updates

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@HolgerJeromin HolgerJeromin requested a review from a team as a code owner February 10, 2022 11:03
@HolgerJeromin HolgerJeromin requested review from sideshowbarker and removed request for a team February 10, 2022 11:03
@github-actions github-actions bot added the Content:JS JavaScript docs label Feb 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I would even go further with the first part.

@teoli2003 teoli2003 merged commit e403ac6 into mdn:main Feb 10, 2022
@teoli2003
Copy link
Contributor

Thanks a lot!

@HolgerJeromin HolgerJeromin deleted the patch-1 branch February 10, 2022 12:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants