Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScreenOrientation.lock() updates for FF97 #11684

Merged
merged 7 commits into from
Jan 5, 2022
Merged

ScreenOrientation.lock() updates for FF97 #11684

merged 7 commits into from
Jan 5, 2022

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jan 3, 2022 •
edited
Loading

ScreenOrientation.lock() has been updated for FF97 - see https://bugzilla.mozilla.org/show_bug.cgi?id=1697647. This does general improvements including an example.

This is in draft because I'm still testing/working on the example.

Rest of work for this tracked in #11594

@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/ScreenOrientation/lock
Title: ScreenOrientation.lock()
on GitHub

No new external URLs

(this comment was updated 2022-01-04 03:58:38.259791)

This was referenced Jan 3, 2022
Closed
Closed
@hamishwillee hamishwillee marked this pull request as ready for review January 4, 2022 03:56
@hamishwillee hamishwillee requested a review from a team as a code owner January 4, 2022 03:56
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team January 4, 2022 03:56
@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Jan 4, 2022 •
edited
Loading

@sideshowbarker Thanks for initial review. I've tidied this up a little further, and improved the example. The example works on Chrome for Android.

Note, I'm a big fan of these live examples, since they make testing support for a feature in a browser a lot easier, and also verifying that the code in examples actually works and has not ended up with typographic errors. Downside I guess is that they are often larger than you need to get the point across.

@netlify
Copy link

netlify bot commented Jan 5, 2022 •
edited
Loading

❌ Deploy Preview for mdn-contributor failed.

🔨 Explore the source changes: 62aca56

🔍 Inspect the deploy log: https://app.netlify.com/sites/mdn-contributor/deploys/61d4f2f56835410008ce5ab4

@sideshowbarker sideshowbarker merged commit b083dc8 into mdn:main Jan 5, 2022
wbamberg added a commit to wbamberg/content that referenced this pull request Jan 5, 2022
@wbamberg
Merge remote-tracking branch 'upstream/main' into js-la-object-orient…
f0145df 
…ed-js

* upstream/main: (286 commits)
  MediaQueryList removeListener depreciation (mdn#11749)
  Update index.md to make text time independent (mdn#11748)
  Corrected typos in multiple pages (mdn#11746)
  Fix some awkward hyperlink formatting (mdn#11740)
  HTMLElement .offset[height|left|parent|top|width] are stable removed experimental icon (mdn#11741)
  Typo (mdn#11742)
  Fix comments (mdn#11756)
  Restore line breaks in the `<dd>`s (mdn#11757)
  Added clarification when property reflects the HTML attribute (mdn#11751)
  Bump technote-space/get-diff-action from 5.0.2 to 6.0.1 (mdn#11755)
  Change "validate" to "check" (mdn#11550)
  Clarify behavior of Array.p.lastIndexOf() fromIndex arg (mdn#11731)
  FF97 Add experimental feature for ScreenOrientation.lock() (mdn#11705)
  Correcting one of the example provided (mdn#11709)
  Adds support for AbortSignal.reason and related items (mdn#11708)
  Added documentation on missing property (mdn#11721)
  Bump @mdn/yari from 0.5.4 to 0.6.6 (mdn#11722)
  Fix: bring gl.FRAMEBUFFER target in line with  the spec (mdn#11732)
  ScreenOrientation.lock() updates for FF97 (mdn#11684)
  Reword actualBoundingBoxLeft description (mdn#11290)
  ...
@hamishwillee hamishwillee deleted the ff97_screenlock branch January 6, 2022 23:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @sideshowbarker