Document conditions for popup-opening by window.open, and BarProp values

[arai-a]

for whatwg/html#6530

• Added popup feature
• Added description about requesting popup
• Changed examples not to use the backward-compat-only UI parts features
• Updated BarProp.visible to reflect popup request
• Moved outerWidth/outerHeight to obsolete features page

Summary

Update windowFeatures parameter behavior for window.open, and also BarProp.visible behavior, to follow the spec change in whatwg/html#6530.

Motivation

Reflect the latest spec.

Supporting details

Firefox: fixed in 96 (currently Nightly) https://bugzilla.mozilla.org/show_bug.cgi?id=1701001
Chrome: in progress https://bugs.chromium.org/p/chromium/issues/detail?id=1192701
Safari: bug is filed https://bugs.webkit.org/show_bug.cgi?id=223751

Related issues

• Add window.open popup feature and BarProp.visible value update browser-compat-data#13322

Metadata

• Adds a new document
• Rewrites (or significantly expands) a document
• Fixes a typo, bug, or other error

[github-actions]

Preview URLs

• https://pr10339.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/BarProp/visible
• https://pr10339.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Window/open/Obsolete_features
• https://pr10339.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Window/open

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Window/open/Obsolete_features
Title: Obsolete features
on GitHub
Flaw count: 2

• broken_links:
  • Is currently http:// but can become https://
  • Is currently http:// but can become https://

External URLs

URL: /en-US/docs/Web/API/BarProp/visible
Title: BarProp.visible
on GitHub

No new external URLs

---

URL: /en-US/docs/Web/API/Window/open
Title: Window.open()
on GitHub

• https://html.spec.whatwg.org/multipage/window-object.html (1 time) (Note! This may be a new URL 👀)

---

URL: /en-US/docs/Web/API/Window/open/Obsolete_features
Title: Obsolete features
on GitHub

No new external URLs

(this comment was updated 2021-11-08 08:39:53.537455)

[arai-a]

Sorry, my description was unclear.

for "popup" feature, "not-present" and "present with disabled" has different semantics.
"not-present" fallback to other conditions, and "present with disabled" explicitly "don't request" without checking other features.
https://html.spec.whatwg.org/#popup-window-is-requested

[sideshowbarker]

Sorry, my description was unclear.

for "popup" feature, "not-present" and "present with disabled" has different semantics.
"not-present" fallback to other conditions, and "present with disabled" explicitly "don't request" without checking other features.
https://html.spec.whatwg.org/#popup-window-is-requested

Ok, thanks ー I'll make another edit to re-correct that

[arai-a]

the basic algorithm that the document is supposed to cover is that:

• if "popup" is present, then:
  • if enabled (boolean value is true), then request popup
  • otherwise, do not request popup
• otherwise:
  • if windowFeatures is empty, then do not request popup
  • otherwise:
    • if there's any other feature than noopener and noreferer, then request popup
      • (this has more complex backward-compat condition about UI features, but I don't want to describe it in the document, for simplicity)
    • otherwise, do not request popup

so I mentioned about popup in position and size (left/top/width/height),
and not mentioned about popup in noopener/noreferer.

[arai-a]

oh, I thought the description becomes comment instead of commit message.

anyway, thank you for reviewing :)
I think it's better omitting the "not present" case from the first section, and let the later "Otherwise" handle it,
so that it checks other features.

[arai-a]

the difference is that:
width=500,height=500 (not present) requests popup, and
width=500,height=500,popup=no (present and disabled) doesn't request popup.

(in both case, whether to handle width/height, and whether to open new window or tab, are browser-dependent)

[sideshowbarker]

oh, I thought the description becomes comment instead of commit message.

anyway, thank you for reviewing :) I think it's better omitting the "not present" case from the first section, and let the later "Otherwise" handle it, so that it checks other features.

Please go ahead and commit a change for that

[arai-a]

done in dbd3667

[sideshowbarker]

@arai-a Please re-review the current state of the content in the branch. If it all looks accurate to you, then I will merge it later this afternoon. (Right now I’m going to take a break for a couple hours or so.)

[arai-a]

Thank you again!

tweaked the position/size description not to mention boolean feature handling.
otherwise it looks good :)

[sideshowbarker]

Sorry! Only just now realized I’d forgotten to merge this…

[sideshowbarker]

@arai-a Really great work (including the related spec work you did) — congrats on landing your first docs change here, and welcome aboard 🎉