Remove never-shipped Bluetooth APIs #9975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The many all-No entries makes the compat tables look very messy: https://developer.mozilla.org/en-US/docs/Web/API/BluetoothDevice#browser_compatibility https://developer.mozilla.org/en-US/docs/Web/API/BluetoothAdvertisingData#browser_compatibility https://developer.mozilla.org/en-US/docs/Web/API/BluetoothRemoteGATTService#browser_compatibility The removed APIs were all confirmed to not be supported on Chrome 90 on macOS using these generated tests: https://mdn-bcd-collector.appspot.com/tests/api/BluetoothDevice https://mdn-bcd-collector.appspot.com/tests/api/BluetoothAdvertisingData https://mdn-bcd-collector.appspot.com/tests/api/BluetoothRemoteGATTService Additionally, Chromium's IDL shows most of this isn't there: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/bluetooth/bluetooth_device.idl;drc=02d4b05485a75ab044b42658284ae1134da1ebb9 The exception is watchAdvertisements/watchingAdvertisements which are behind a flag, but removed anyway rather than filling out the data. The getIncludedServices entry was also an outlier, it's not actually in Chromium so the existing compat data was wrong.
github-actions
bot
added
the
data:api
jpmedley
approved these changes
Apr 30, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
May 6, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
May 6, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The many all-No entries makes the compat tables look very messy:
https://developer.mozilla.org/en-US/docs/Web/API/BluetoothDevice#browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/BluetoothAdvertisingData#browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/BluetoothRemoteGATTService#browser_compatibility
The removed APIs were all confirmed to not be supported on Chrome 90 on
macOS using these generated tests:
https://mdn-bcd-collector.appspot.com/tests/api/BluetoothDevice
https://mdn-bcd-collector.appspot.com/tests/api/BluetoothAdvertisingData
https://mdn-bcd-collector.appspot.com/tests/api/BluetoothRemoteGATTService
Additionally, Chromium's IDL shows most of this isn't there:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/bluetooth/bluetooth_device.idl;drc=02d4b05485a75ab044b42658284ae1134da1ebb9
The exception is watchAdvertisements/watchingAdvertisements which are
behind a flag, but removed anyway rather than filling out the data.
The getIncludedServices entry was also an outlier, it's not actually in
Chromium so the existing compat data was wrong.