Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AbortSignal.abort() static method #9648

Merged
merged 4 commits into from
Mar 30, 2021
Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Mar 29, 2021

AbortSignal.abort() static method added to spec very recently

Should AbortSignal still be marked as experimental?

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 29, 2021
api/AbortSignal.json Outdated Show resolved Hide resolved
api/AbortSignal.json Outdated Show resolved Hide resolved
api/AbortSignal.json Outdated Show resolved Hide resolved
"version_added": "89"
},
"firefox": {
"version_added": "88"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in Firefox 88 beta, and that it's not in Firefox 87.

hamishwillee and others added 3 commits March 30, 2021 10:36
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
@hamishwillee
Copy link
Collaborator Author

Thanks for review @foolip. I've fixed those suggestions. Let me know if you think we also need to remove the experimental flag on AbortSignal.

@foolip
Copy link
Collaborator

foolip commented Mar 30, 2021

@hamishwillee yes given how widely it is supported I think AbortSignal shouldn't be experimental. But maybe this method should. In any case it's fine to change that in another PR.

@foolip foolip merged commit 97e18ab into mdn:main Mar 30, 2021
@hamishwillee hamishwillee deleted the abortsignal_abort branch April 5, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants