-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipboard Item updates #9330
Clipboard Item updates #9330
Conversation
updating
Updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Rumyra. In line comments, I've proposed a couple of changes. Thank you for the PR!
Co-authored-by: Daniel D. Beck <[email protected]>
Thanks again @ddbeck - updated as per feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. This can go out with today's release. Thank you! 🎉
\o/ thank you @ddbeck ! I'm v happy I only revised this once 😆 Very appreciative of the feedback 👍 |
@Rumyra no problem! And there's lots to learn about BCD. The revisions aren't a sign that something is wrong, just that this stuff is complicated. |
A checklist to help your pull request get merged faster:
Adding data to reflect current spec https://www.w3.org/TR/clipboard-apis/#clipboard-interface
https://bugs.chromium.org/p/chromium/issues/detail?id=1014310
mdn/content#2514
Testing code in Chrome 90 (Canary), FF 87 and Safari 14
Tests pass ☑️
As above