Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard Item updates #9330

Merged
merged 13 commits into from
Mar 4, 2021
Merged

Clipboard Item updates #9330

merged 13 commits into from
Mar 4, 2021

Conversation

Rumyra
Copy link
Contributor

@Rumyra Rumyra commented Mar 4, 2021

A checklist to help your pull request get merged faster:

  • Summarize your changes

Adding data to reflect current spec https://www.w3.org/TR/clipboard-apis/#clipboard-interface

  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)

https://bugs.chromium.org/p/chromium/issues/detail?id=1014310
mdn/content#2514

  • Data: if you tested something, describe how you tested with details like browser and version

Testing code in Chrome 90 (Canary), FF 87 and Safari 14

  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)

Tests pass ☑️

  • Link to related issues or pull requests, if any

As above

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 4, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Rumyra. In line comments, I've proposed a couple of changes. Thank you for the PR!

api/ClipboardItem.json Outdated Show resolved Hide resolved
api/ClipboardItem.json Outdated Show resolved Hide resolved
api/ClipboardItem.json Outdated Show resolved Hide resolved
@Rumyra
Copy link
Contributor Author

Rumyra commented Mar 4, 2021

Thanks again @ddbeck - updated as per feedback ☺️

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This can go out with today's release. Thank you! 🎉

@ddbeck ddbeck merged commit 40083de into mdn:master Mar 4, 2021
@Rumyra
Copy link
Contributor Author

Rumyra commented Mar 4, 2021

\o/ thank you @ddbeck ! I'm v happy I only revised this once 😆 Very appreciative of the feedback 👍

@ddbeck
Copy link
Collaborator

ddbeck commented Mar 4, 2021

@Rumyra no problem! And there's lots to learn about BCD. The revisions aren't a sign that something is wrong, just that this stuff is complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants