-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm run diff
#7486
Add npm run diff
#7486
Conversation
Hey @saschanaz, this is LGTM for the most part and I'd love to add it in! Would you mind rebasing this real quick? |
Done, but I only have npm 8. Feel free to regenerate package-lock.json. |
We upgraded to use NodeJS v16, which uses NPM v8 and package-lock v2. Looks like this one needs another quick rebase! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is LGTM and I'm excited to integrate it! I'd like @foolip's review as well though, since this builds upon his work!
This pull request has merge conflicts that must be resolved before we can merge this. |
1 similar comment
This pull request has merge conflicts that must be resolved before we can merge this. |
This pull request has merge conflicts that must be resolved before we can merge this. |
This pull request has merge conflicts that must be resolved before we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, happened to notice a small thing -- could we use ~
vs. ^
for the version number to maintain consistency between the dependencies?
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Odd, the CI should've failed because |
Could you do that for me, I'm on bed 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thank you! This is LGTM, and essential for some plans Open Web Docs has, so I'll merge this now!
What plans, BTW? 👀 |
A checklist to help your pull request get merged faster:
This intends to succeed what @foolip did in #6862 using git commands. Example:
npm run diff
is a shorthand ofnpm run diff origin/HEAD
, which compares current changes againstorigin/HEAD
. The longhand is primarily for debugging and test.