Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IE 6 as ranged version #7337

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Conversation

queengooborg
Copy link
Contributor

This PR adds Internet Explorer 6 as a ranged version. IE 6 was released all the way back in 2001, and is the oldest version of IE supported by BrowserStack. While I own VMs that are able to test IE 1-5.5, these versions of IE are so old that it is irrelevant to developers whether it was implemented in 2001, or all the way back in 1996. (Furthermore, the mdn-bcd-collector project is not compatible with IE 5 or lower, thus making testing inefficient -- much like the case of Safari 1-2 when we added Safari 4 as a range.)

@queengooborg queengooborg requested a review from ddbeck as a code owner November 11, 2020 18:00
@github-actions github-actions bot added docs Issues or pull requests regarding the documentation of this project. linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project. labels Nov 11, 2020
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this, but over to @ddbeck

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems reasonable. IE6 was the browser for a long time. Seems like a nice enough boundary.

This needs a rebase though—happy to review and merge when that's done.

@queengooborg
Copy link
Contributor Author

What rebase? >:3

(Thinking about it by the way, should we perhaps sort that dictionary alphabetically?)

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 13, 2020

(Thinking about it by the way, should we perhaps sort that dictionary alphabetically?)

Yeah, that'd be good. Want to include that now?

@queengooborg
Copy link
Contributor Author

Sure thing -- done!

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 214fd40 into mdn:master Nov 13, 2020
@queengooborg queengooborg deleted the linter/ie-6-range branch November 13, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues or pull requests regarding the documentation of this project. linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants