-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IE 6 as ranged version #7337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this, but over to @ddbeck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, seems reasonable. IE6 was the browser for a long time. Seems like a nice enough boundary.
This needs a rebase though—happy to review and merge when that's done.
What rebase? >:3 (Thinking about it by the way, should we perhaps sort that dictionary alphabetically?) |
Yeah, that'd be good. Want to include that now? |
Sure thing -- done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
This PR adds Internet Explorer 6 as a ranged version. IE 6 was released all the way back in 2001, and is the oldest version of IE supported by BrowserStack. While I own VMs that are able to test IE 1-5.5, these versions of IE are so old that it is irrelevant to developers whether it was implemented in 2001, or all the way back in 1996. (Furthermore, the mdn-bcd-collector project is not compatible with IE 5 or lower, thus making testing inefficient -- much like the case of Safari 1-2 when we added Safari 4 as a range.)