Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebExtensions compatibility for Firefox for Android 79 #6590

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

kewisch
Copy link
Contributor

@kewisch kewisch commented Aug 28, 2020

With Firefox for Android 79, we're building on a new browser platform. As
such, many WebExtensions APIs needed to be re-implemented from scratch.
With the release of 79 we haven't yet achieved WebExtension API parity,
therefore this changeset is updating API compatibility. We are working
on restoring the remaining APIs. Note also we have added a few APIs that
were not supported before.

@github-actions github-actions bot added data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions labels Aug 28, 2020
Copy link
Contributor

@agi agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I went through the files to see if I could spot anything.

@agi agi force-pushed the master branch 3 times, most recently from 11ad9f0 to c6b1c41 Compare August 28, 2020 21:36
@kewisch kewisch marked this pull request as ready for review August 28, 2020 22:11
@kewisch kewisch requested a review from wbamberg as a code owner August 28, 2020 22:11
@wbamberg wbamberg removed their request for review August 29, 2020 00:14
@kewisch
Copy link
Contributor Author

kewisch commented Aug 31, 2020

@chrisdavidmills @ddbeck On our end this is ready to go. We'd appreciate a quick look to make sure things are correct.

@queengooborg
Copy link
Contributor

Hey @kewisch, thanks for your PR and welcome to BCD! I noticed that you're also updating the browser data in this PR, and it appears you have a different release date for Fenix 79 than I had obtained. May I confirm where you obtained the release date?

With Firefox for Android 79, we're building on a new browser engine. As
such, many WebExtensions APIs needed to be re-implemented from scratch.
With the release of 79 we haven't yet achieved WebExtension API parity,
therefore this changeset is updating API compatibility. We are working
on restoring the remaining APIs. Note also we have added a few APIs that
were not supported before.

Co-authored-by: Agi Sferro <[email protected]>
@kewisch
Copy link
Contributor Author

kewisch commented Sep 1, 2020

Thanks for flagging. I thought I picked it from the release notes, but while double checking it looks like I might have been on the wrong page. I've reverted the release date change in this PR.

@queengooborg queengooborg removed the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Sep 1, 2020
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I'm trusting that you're an authoritative source on the data here, so I have only one style suggestion before we merge this.

webextensions/api/browsingData.json Outdated Show resolved Hide resolved
@queengooborg queengooborg changed the title Update API compatibility for Firefox for Android 79 Update WebExtensions compatibility for Firefox for Android 79 Sep 4, 2020
@kewisch
Copy link
Contributor Author

kewisch commented Sep 9, 2020

Thanks @ddbeck , I've made the requested changes. All good to squash and merge when you are ready.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kewisch! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants