-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WebExtensions compatibility for Firefox for Android 79 #6590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! I went through the files to see if I could spot anything.
11ad9f0
to
c6b1c41
Compare
@chrisdavidmills @ddbeck On our end this is ready to go. We'd appreciate a quick look to make sure things are correct. |
Hey @kewisch, thanks for your PR and welcome to BCD! I noticed that you're also updating the browser data in this PR, and it appears you have a different release date for Fenix 79 than I had obtained. May I confirm where you obtained the release date? |
With Firefox for Android 79, we're building on a new browser engine. As such, many WebExtensions APIs needed to be re-implemented from scratch. With the release of 79 we haven't yet achieved WebExtension API parity, therefore this changeset is updating API compatibility. We are working on restoring the remaining APIs. Note also we have added a few APIs that were not supported before. Co-authored-by: Agi Sferro <[email protected]>
Thanks for flagging. I thought I picked it from the release notes, but while double checking it looks like I might have been on the wrong page. I've reverted the release date change in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I'm trusting that you're an authoritative source on the data here, so I have only one style suggestion before we merge this.
Co-authored-by: Daniel D. Beck <[email protected]>
Thanks @ddbeck , I've made the requested changes. All good to squash and merge when you are ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @kewisch! 🎉
With Firefox for Android 79, we're building on a new browser platform. As
such, many WebExtensions APIs needed to be re-implemented from scratch.
With the release of 79 we haven't yet achieved WebExtension API parity,
therefore this changeset is updating API compatibility. We are working
on restoring the remaining APIs. Note also we have added a few APIs that
were not supported before.