Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chrome versions for DOMTokenList API #6564

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Aug 26, 2020

This PR fixes version numbers for the DOMTokenList API based upon manual testing. The API was actually implemented in Chrome 8; this PR corrects the data to match. All the features listed as supported in Chrome 1 were tested in Chrome 8 and confirmed functional.

Found during the creation of PRs from mdn-bcd-collector.

@ghost ghost added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 26, 2020
@jpmedley jpmedley self-assigned this Aug 26, 2020
Copy link
Contributor

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the webview_android at line 41 be "≤37"?

@queengooborg
Copy link
Collaborator Author

Sure thing, fixed!

@foolip
Copy link
Collaborator

foolip commented Aug 27, 2020

@vinyldarkscratch it would make review easier if you could put some more details into the commit message about what you tested, even when testing manually. Here I suspected (incorrectly) that originally the DOMTokenList interface object wasn't exposed, or maybe even was called something else. I wrote http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8382 to check it out.

This was implemented in WebKit in https://trac.webkit.org/changeset/68440/webkit. That was WebKit version 534.10, verified by the process in https://wiki.developer.mozilla.org/en-US/docs/MDN/Contribute/Processes/Matching_features_to_browser_version#Safari (which I just updated).

Chrome 8 was using precisely WebKit 534.10, so this checks out.

api/DOMTokenList.json Outdated Show resolved Hide resolved
api/DOMTokenList.json Outdated Show resolved Hide resolved
api/DOMTokenList.json Outdated Show resolved Hide resolved
api/DOMTokenList.json Outdated Show resolved Hide resolved
api/DOMTokenList.json Outdated Show resolved Hide resolved
api/DOMTokenList.json Outdated Show resolved Hide resolved
api/DOMTokenList.json Outdated Show resolved Hide resolved
@foolip
Copy link
Collaborator

foolip commented Aug 27, 2020

Another thing I notice here is the inconsistency between api.DOMTokenList and api.Element.classList. These were introduced at the same time.

@foolip
Copy link
Collaborator

foolip commented Aug 27, 2020

I've filed #6571 about a possible lint that would have flagged inconsistency between api.DOMTokenList and api.Element.classList.

@foolip
Copy link
Collaborator

foolip commented Aug 27, 2020

Another little wrinkle. https://developer.mozilla.org/en-US/docs/Web/API/Element/classList#Browser_compatibility notes that this was originally not supported for SVG elements in Internet Explorer and Edge. This was actually the case in WebKit as well, and was fixed in https://trac.webkit.org/changeset/125092/webkit. That was WebKit 537.4, which ought to have been Chrome 22, Safari 6.1. and Safari for iOS 7.

I don't really think it'd be valuable to document this, but what should the criteria be for something like this?

Co-authored-by: Philip Jägenstedt <[email protected]>
@foolip foolip dismissed jpmedley’s stale review August 28, 2020 09:22

webview_android versions are now exact

@foolip
Copy link
Collaborator

foolip commented Aug 28, 2020

Thanks for the fixes, merging this now!

@foolip foolip merged commit 2dd5729 into mdn:master Aug 28, 2020
@queengooborg queengooborg deleted the api/DOMTokenList branch August 28, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants