-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sharedwokers #6084
Update sharedwokers #6084
Conversation
Edge didn't have support until 79 IE didn't have support
Chrome Android doesn't support it Opera Android removed support in v14 Samsung Internet only had support in v4-4.2
Sorry, i'm unsure how to solve the last parser errors. They are marked
|
Hey @atjn, thank you for your PR! I have not reviewed it for the content just yet, but I can help shed some light on the linter errors. To summarize, a subfeature cannot be supported by a browser if its parent feature is unsupported. Considering the version these features were added to Firefox, I think it's safe to say that they were not present in a version of Opera Android or Samsung Internet where ServiceWorker support is stated in this PR, so we can just set these to |
Sorry about that! We haven't worked on that issue yet, unfortunately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! 👍
The support data for
SharedWorker
on Caniuse is very different from the one on MDN.I ran some tests to align them, and it seems like MDN is wrong in this case. I have checked the history of the MDN table all the way back to the initial commit (#947), and i cannot find any source for the numbers on MDN.
Closes #5850
Closes Fyrd/caniuse#5387
Accurate changes
I ran manual testing for these changes with the caniuse test and some manual console work on the side to make sure the test was correct. I tested the current stable versions and the versions immediately before and after any alleged change according to either dataset.
The changes also align perfectly with the caniuse support table.
IE
10-11
->false
Edge
12+
->79+
Mostly acccurate changes
These changes might not be perfect, but they bring the dataset much closer to the truth.
I have no way of testing older mobile browsers properly, but the current versions of these browsers, plus some random old versions i have access to (released 2013 - 2016) do not support
SharedWorker
.The tests i was able to perform all aligned with caniuse, so i have based the specific details on the caniuse data.
Chrome Android
true
->false
Opera Android
11+
->11-12.1
This makes perfect sense, since 12.1 was the last version before Opera became Chromium-based.
Samsung Internet
true
->4-4.2
This data looks a little suspicious to me, but is definetely possible.
Still needs fixing
A lot of compatibility data on the SharedWorkerGlobalScope is showing support before
SharedWorker
was supported. Pretty sure that's wrong.It would be great if you could fix (no, Github, i'm not fixing it) #4206 (Mozilla bug 1417902 #3). I spent a solid 20 minutes being confused about that and almost rewrote my commit even though it was correct.