Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constructor test from styling test file #5672

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Remove constructor test from styling test file #5672

merged 1 commit into from
Apr 3, 2020

Conversation

queengooborg
Copy link
Collaborator

This PR removes the constructor description test from the styling test file. Since this is already tested by our descriptions test, we have no need for testing it twice.

@ghost ghost added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Feb 7, 2020
@queengooborg queengooborg mentioned this pull request Mar 27, 2020
Closed
23 tasks
Elchi3
Elchi3 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the other test also checks if you have the correct constructor name. Agree to remove this one. Thank you! 👍

@Elchi3 Elchi3 merged commit 09dfeaa into mdn:master Apr 3, 2020
@queengooborg queengooborg deleted the linter/styling-constructor branch April 3, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3