Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS hanging-punctuation: Safari doesn't support force-end #5637

Merged
merged 2 commits into from
Feb 7, 2020
Merged

CSS hanging-punctuation: Safari doesn't support force-end #5637

merged 2 commits into from
Feb 7, 2020

Conversation

queengooborg
Copy link
Collaborator

This PR fixes #5541. Safari doesn't have implementation for force-end, however it is recognized. As such, this adds a note stating as such.

@ghost ghost added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jan 31, 2020
@Elchi3
Copy link
Member

Elchi3 commented Feb 6, 2020

Should partial_implementation be true here?

@queengooborg
Copy link
Collaborator Author

Oh yeah, the value is a part of the spec. Sure thing, I’ll add the partial implementation flag!

Elchi3
Elchi3 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit f7feb39 into mdn:master Feb 7, 2020
@queengooborg queengooborg deleted the css/hanging-punctuation branch February 7, 2020 17:05
@jamesnw jamesnw mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safari does not support force-end keyword value of hanging-punctuation property
2 participants
@queengooborg @Elchi3