Add tips/hints to version test #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
linter 🏡
23 tasks
caugner
approved these changes
May 13, 2022
test/linter/test-versions.js
Outdated
| @@ -103,12 +111,24 @@ function checkVersions(supportData, relPath, logger) { | |||
| for (const statement of supportStatements) { | |||
| if (!isValidVersion(browser, statement.version_added)) { | |||
There was a problem hiding this comment.
Would be nice to deduplicate these two blocks into a for ... of loop:
for (const property of ['version_added', 'version_removed']) {
// ...
}
test/linter/test-versions.js
Outdated
| @@ -103,12 +111,24 @@ function checkVersions(supportData, relPath, logger) { | |||
| for (const statement of supportStatements) { | |||
| if (!isValidVersion(browser, statement.version_added)) { | |||
There was a problem hiding this comment.
Would be nice to deduplicate these two blocks into a for ... of loop:
for (const property of ['version_added', 'version_removed']) {
// ...
}
|
This pull request has merge conflicts that must be resolved before we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tips to the version linter for common mistakes contributors may make when creating a PR. This was inspired by a comment Daniel posted on a suggestion to rename "safari_ios" to "ios":
Well, here you go, @ddbeck -- one fresh addition of code hot off the grill! 😄