Update background-repeat data #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug shows the implementation; versions inferred from dates. https://bugs.webkit.org/show_bug.cgi?id=28635
Inferred versions based on the date of this commit: https://chromium.googlesource.com/chromium/src.git/+/5ea3d8d2563187f1d17ed850a9373a3dda42a606
ddbeck
added
the
data:css
ddbeck
force-pushed
the
background-repeat
branch
from
cc08266 to
1f2b308
Compare
11 tasks
|
LGTM Chrome and WebView. |
queengooborg
approved these changes
Jun 23, 2019
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Jul 13, 2022
The original 7 was based on commit dates: mdn#4337 The commits in question were in WebKit trunk version 538.1: WebKit/WebKit@35a4cb0 https://github.com/WebKit/WebKit/blob/35a4cb02118dcf9b59d24eea302be5a3aeaa46f2/Source/WebCore/Configurations/Version.xcconfig WebKit/WebKit@611d197 https://github.com/WebKit/WebKit/blob/611d1979098926c1ac674a0a6a08e592bb2127e5/Source/WebCore/Configurations/Version.xcconfig That maps to Safari 8.
queengooborg
pushed a commit
that referenced
this pull request
Jul 13, 2022
…16960) The original 7 was based on commit dates: #4337 The commits in question were in WebKit trunk version 538.1: WebKit/WebKit@35a4cb0 https://github.com/WebKit/WebKit/blob/35a4cb02118dcf9b59d24eea302be5a3aeaa46f2/Source/WebCore/Configurations/Version.xcconfig WebKit/WebKit@611d197 https://github.com/WebKit/WebKit/blob/611d1979098926c1ac674a0a6a08e592bb2127e5/Source/WebCore/Configurations/Version.xcconfig That maps to Safari 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4295, I researched
background-repeat. This was a complicated one!background-repeatSince I was here making a bunch of other changes, I mirrored from
background-repeatfrom Safari to Safari for iOS and from Chrome to Samsung Internet. A rather old feature, so I figured this was reasonable.2-valueround_spaceMaybe we should split these in two? I decided not to for a cleaner diff, but I could add that change too.
Chrome
caniuse says 32 without citation. I went digging.
This bug shows
roundwas added no later than 31: https://bugs.chromium.org/p/chromium/issues/detail?id=331683This bug shows it wasn't working in 28: https://bugs.chromium.org/p/chromium/issues/detail?id=263310
This comment on a Firefox bug suggests it still wasn't working in Chrome in 29: https://bugzilla.mozilla.org/show_bug.cgi?id=913153#c11
By process of elimination, that leaves us with Chrome 30.
Opera: mirrored from Chrome.
Safaris
The dates on a bunch of bugs and change sets seem to show that it was added to WebKit in August, 2013, meaning no earlier than Safari 7 by release date:
caniuse also reports version 7. I inferred iOS 8 based on the WebKit versions in our data set.
Samsung Internet: mirrored from Chrome.