Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark 41 -webkit-* properties as not standards track #22718

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Mar 27, 2024

None of these have spec URLs and none of them appear in a checkout of https://github.com/w3c/webref, so they aren't defined in any spec that webref knows about.

These are from #21621, excluding the 5 webkit-mask-box-image-* properties which are defined by https://compat.spec.whatwg.org/.

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Mar 27, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an oversight in #21621. Would you mind going the extra mile and fixing this for all features that that PR added?

@foolip
Copy link
Collaborator Author

foolip commented Mar 28, 2024

@Elchi3, sure thing! Of the 46 properties added in #21621, a few appear in webref.

https://compat.spec.whatwg.org/ defined a bunch of -webkit-mask-box-image aliases, and I think we should fold these into the standard property in BCD.

-webkit-app-region is mention in https://wicg.github.io/manifest-incubations/#dfn-webkit-app-region, but explicitly as non-standard.

I will update everything except -webkit-mask-box-image here.

None of these have spec URLs and none of them appear in a checkout of
https://github.com/w3c/webref, so they aren't defined in any spec that
webref knows about.

These are from mdn#21621,
excluding the 5 webkit-mask-box-image-* properties which are defined by
https://compat.spec.whatwg.org/.
@foolip foolip changed the title Mark 15 -webkit-* properties as not standards track Mark 41 -webkit-* properties as not standards track Mar 28, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going the extra miles and providing an in-depth review here! LGTM 👍

@Elchi3 Elchi3 merged commit 6c3a2b4 into mdn:main Mar 28, 2024
6 checks passed
@foolip foolip deleted the webkit-props branch March 28, 2024 14:17
@foolip
Copy link
Collaborator Author

foolip commented Mar 28, 2024

I have filed #22727 about the remaining 5 properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants