-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize linters and fixers #22650
Conversation
Why was this merged without review? |
We had agreed to do this during the BCD call on March 12th. I didn't think this would require review since it is solely reorganizing internal infrastructure. I see this had created merge conflicts for one of your PRs, though. Apologies for that -- happy to fix that right away! |
It would have been useful to still review in more details. In meetings we usually only assess if a PR makes sense generally, ie. if we agree with the notion of it and/or general direction. These file names seem not ideal: test-browsers-data.ts Why not omit the first "test"? |
That's a fair point. I figured that this particular change was straightforward enough that it wouldn't need a thorough technical review. The filenames for the linters is something that I've also been wanting to update to remove the redundant |
This PR reorganizes the linters and fixers structure, as discussed in the last BCD meeting. This places all of the fixer scripts under the same folder that the linters are, and renames the folder from
test/
tolint/
.This ensures both better organization and prepares for a potential linter overhaul in the future.