Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SVG event global attributes #22522

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Remove SVG event global attributes #22522

merged 1 commit into from
Mar 5, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR removes the SVG event global attributes from BCD, matching the same change made a while ago for HTML event global attributes.

@queengooborg queengooborg requested a review from Elchi3 March 4, 2024 13:49
@github-actions github-actions bot added the data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG label Mar 4, 2024
Elchi3
Elchi3 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a content update to remove the onclick reference.

@Elchi3 Elchi3 added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Mar 4, 2024
@queengooborg queengooborg mentioned this pull request Mar 4, 2024
Merged
@queengooborg
Copy link
Collaborator Author

Just submitted a content PR!

@queengooborg queengooborg merged commit 4298385 into main Mar 5, 2024
8 checks passed
@queengooborg queengooborg deleted the svg/events-attributes branch March 5, 2024 04:05
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3