Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing css.properties.z-index.auto feature #22511

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR adds the missing auto member of the z-index CSS property. The data comes from the mdn-bcd-collector project (v10.9.0).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/z-index/auto

This PR adds the missing `auto` member of the `z-index` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.9.0).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/z-index/auto
@queengooborg queengooborg added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Mar 4, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be more careful about the mirrored versions.

css/properties/z-index.json Show resolved Hide resolved
},
"firefox_android": "mirror",
"ie": {
"version_added": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we're not maintaining IE but this data is very likely wrong. Can you omit IE data?

Suggested change
"version_added": false
"version_added": "4"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately our linter prevents us from omitting IE data since it is a desktop browser, so we'll have to tweak the linter. Should we do so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I think very often this would be the same IE version as for the parent feature or false.

css/properties/z-index.json Outdated Show resolved Hide resolved
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Elchi3 Elchi3 merged commit d46ed5d into mdn:main Mar 4, 2024
6 checks passed
@queengooborg queengooborg deleted the css/properties/z-index/auto/additions branch March 4, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants