Add missing features for background-repeat CSS property #22329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the missing features of the `background-repeat` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.9.0). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/background-repeat
queengooborg
added
the
data:css 🎨
hamishwillee
approved these changes
Mar 4, 2024
Elchi3
reviewed
Mar 5, 2024
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "≤15" |
There was a problem hiding this comment.
Why "≤15"? The background-repeat property without the no-repeat, repeat, repeat-x and repeat-y values is not functional... So, this seems very safe to be marked as Firefox 1.
There was a problem hiding this comment.
I couldn't test Firefox 14 and earlier because the collector's property testing function isn't compatible (an argument issue, I believe). So, at first, I would add this range (or "≤16" before I realized I could test on Fx 15) just to play it safe. Eventually, I realized that marking the value as supported since the earliest version was a safe bet.
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing features of the
background-repeatCSS property. The data comes from the mdn-bcd-collector project (v10.9.0).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/background-repeat