Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete is not a global attribute; move to <form> & <textarea> #21929

Merged
merged 7 commits into from
Jun 14, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 14, 2024

Summary

the autocomplete attibute should not treated as html global attribute

removed in favor of #21895 , which add the autocomplete attibute to the <input> and <select>
element

also, the autocomplete attibute is already added to <form> and <textarea> element yet

for dom, the autocomplete has existed in HTMLFormElement HTMLInputElement HTMLSelectElement HTMLTextAreaElement yet

the BCD of the three new value will added to those BCD under html elements

Test results and supporting details

Related issues

Depends on #21895

Fixes #21790

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 14, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 17, 2024 18:12
html/elements/form.json Outdated Show resolved Hide resolved
html/elements/textarea.json Outdated Show resolved Hide resolved
@Elchi3
Copy link
Member

Elchi3 commented Jun 14, 2024

one-time-code supported in Firefox 109 per https://bugzilla.mozilla.org/show_bug.cgi?id=1547294 and #23347

@Elchi3 Elchi3 changed the title Remove html.global_attributes.autocomplete autocomplete is not a global attribute; move to <form> & <textarea> Jun 14, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the delay!

@Elchi3 Elchi3 merged commit 6e0ebe9 into mdn:main Jun 14, 2024
6 checks passed
@skyclouds2001 skyclouds2001 deleted the html.global_attributes.autocomplete branch June 16, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html.global_attributes.autocomplete - the attribute should not regard as a global html attribute
2 participants