-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add complete BCD for Window Management API #20600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two comments.
api/Permissions.json
Outdated
@@ -891,4 +927,4 @@ | |||
} | |||
} | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this change in your PRs and ignored it but then Vinyl opened #20560 so I think we do care about this. Please fix your editor config and don't change this from now on :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, I honestly never knew this was a thing to be concerned about! I have removed the odd newline here and there because I thought they were unnecessary.
I've updated my config so VSCode adds newlines to the end of all files on save, and added the missing ones into this PR. Sorted.
@@ -34,7 +34,7 @@ | |||
}, | |||
"availLeft": { | |||
"__compat": { | |||
"spec_url": "https://w3c.github.io/window-management/#ref-for-dom-screendetailed-availleft", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change necessary?
@sideshowbarker has opinions about where to link in the specs. I think it has to do with where the MDN ribbon appears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The practice followed by the majority of the existing spec URLs is to use the URL for the developer part of the spec, if any. In this case, that’s https://w3c.github.io/window-management/#ref-for-dom-screendetailed-availleft
And yeah the effect of that as far as the rendering of the published specs goes is that it causes the MDN annotation in the spec to be shown next the developer part of the spec (rather than the implementor part).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, makes sense. I've reverted those changes, and added some other developer spec URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you Chris! 👍
* Add complete BCD for Window Management API * Add missing newlines * Update spec URLs to developer defs where possible * Add MDN URLs for ScreenDetailed and ScreenDetails
Summary
The Window Management API was implemented in Chrome 100 (see ChromeStatus entry); this PR provides complete BCD for it (some was available already).
Test results and supporting details
Related issues